Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent drifting after entering system-changing black hole #783

Open
coderCleric opened this issue Feb 22, 2024 · 1 comment · Fixed by #874 or #880
Open

Prevent drifting after entering system-changing black hole #783

coderCleric opened this issue Feb 22, 2024 · 1 comment · Fixed by #874 or #880
Labels
bug Something isn't working

Comments

@coderCleric
Copy link
Contributor

What Happened?

Entering a black hole that changes the system doesn't stop the player from drifting, instead only preventing inputs. This is especially noticeable if the black hole is in a 0G environment without any physical object to stop the player from passing through.

What was supposed to happen?

The player should probably stop moving when they enter the black hole, or at least have the screen turn black so that they can't tell.

Platform

Steam

Mods

Happens with just NH and an addon that adds a black hole.

Logs

No response

@coderCleric coderCleric added the bug Something isn't working label Feb 22, 2024
@JohnCorby JohnCorby mentioned this issue Jun 3, 2024
JohnCorby added a commit that referenced this issue Jun 4, 2024
## Minor features

- Added `parentPath` to scatter. This parent should be at the position
where you'd like to scatter (which would usually be zero).

## Improvements
- Now avoiding unnecessary EndConversation calls. (Fix #859)

## Bug fixes

- Prevents a softlock when at the eye (JohnCorby's fault) (Fix #865)
- Pause on load like in base game (Fix #783)
- Fixed disabled reference frames not being disabled (for the third
time)
- Fixed sectors being rotated on tidally locked bodies
- Fixed scatter not working properly on tidally locked bodies
- Fixed returning to solar system radius not being calculated correctly
- Supposedly fixed rafts but didn't actually (wtf Hawkbar!)
- Stop popups spamming your entire save file potentially.
@xen-42
Copy link
Member

xen-42 commented Jun 4, 2024

This fix was BAD and removes a FEATURE of NH boo!!!!!! I wanna revert it so bad!!!!

Instead of pausing the game entirely (and getting rid of the graphical effects from the ship warping or the audio effects of entering a black hole) we should stop the player relative to the black hole they just entered. Probably move them so that their camera goes inside it just to be safe.

Reopening because I don't consider this truly fixed

@xen-42 xen-42 reopened this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants