Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide Reel loading lag #812

Closed
pikpik-carrot opened this issue Mar 16, 2024 · 0 comments · Fixed by #897 or #902
Closed

Slide Reel loading lag #812

pikpik-carrot opened this issue Mar 16, 2024 · 0 comments · Fixed by #897 or #902
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.

Comments

@pikpik-carrot
Copy link

What Happened?

Slide reels are loaded all at once causing incredibly long load times instead of being loaded asynchronous.

What was supposed to happen?

No response

Platform

None

Mods

No response

Logs

No response

@pikpik-carrot pikpik-carrot added the bug Something isn't working label Mar 16, 2024
@xen-42 xen-42 mentioned this issue Jun 14, 2024
@MegaPiggy MegaPiggy added the fixed in dev Instead of closing issues when you fix them in dev just add this. label Jun 18, 2024
@xen-42 xen-42 closed this as completed in 28038c8 Jun 18, 2024
xen-42 added a commit that referenced this issue Jun 18, 2024
## Major features

- Added `GlobalMusic` module to system config (change end times, bramble
dimension, and final end times music) (Resolves #894)
- Slides are now loaded in the background instead of freezing your game.
Brings load time of current Eyes of the Past dev build from 2.5 minutes
to 40 seconds (hooray). (Fixes #812)

## Improvements

- Setting `parentPath` will be more robust on most props (retries the
build operation until it finds the parent)

## Bug fixes

- Fix quantum planet NRE when body gets updated (astro object gets
recreated)
- Fix custom signal NRE that happens when going to solar system to get
prefabs for eye
- Fixed global bramble music not playing because all dimensions have an
ambient audio volume
- No more infinite load when warping back to Outer Wilds system with the
Vessel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.
Projects
None yet
2 participants