-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow editing the map mode sprite of a planet that's already been loaded #875
Comments
this doesnt happen because nh does not merge planet configs at all contrasting to systems, with are merged into one config and then applied, planet configs are just applied sequentially with no regards to overwrites (because most properties are additive in nature ("add this detail") and not updating a value) |
We could instead generally allow updating the map mode icons of existing planets. This would include modded and stock. In UpdateBody we'd need to find the ShipLogAstroObject that corresponds to the existing planet. Then take its Better yet we just delete those objects entirely and call some of the code from MapModeBuilder.AddShipLogAstroObject and replace them. Or something! |
actually it appears to just Instantiate a new thing for _unviewedObj and just uhhhh forget about (but not delete) whatever existed there before. so if multiple planets go make then i think it would just overwrite but keep the one ones disabled(?) but existing forever |
## Improvements - Map mode icon setting changes now work when updating an existing planet. Fixes #875
## Major features - Updated to work with Patch 15 (fixed game libs + game over text issue) (thanks Jeff from Mobius for pointing that one out!) ## Minor features - New slide reel options. `reelModel` and `reelCondition` parameters for slide reel mesh and material. (#811) - Models: 6-slided, 7-slided, 8-slided, and Whole (7-slided but connected like 8-slided). - Conditions: Antique (Stranger), Pristine (Dreamworld), Rusted (Burnt) - `rotate` parameter added to slide info. Rotates the slide reel item while inside a projector. - Added map marker module with display distance overrides (#847) ## Improvements - Relative spawning when warping with vessel just like vanilla - No more wake up effects for vessel warping - Map mode icon setting changes now work when updating an existing planet. Fixes #875 ## Bug fixes - Fixed nomai lamps on custom vessel looking like they are off - Fixed broken black and white holes on custom vessel - Fixed vessel coordinate orb not unlocking on start - Dialogue replacement can no longer replace dialogue on other planets than the one the config file is for. - Fix seeing solar system before opening your eyes if there was conditional object activation being used - Fix getting stuck in chair when warping back from NH Examples - Fix seeing solar system for one frame when going to the Eye
What Happened?
Changing another NH config's ShipLog.mapMode fields does not properly get applied. Currently tested with revealedSprite and invisibleWhenHidden. I have a mod that is patching another mod and adds these fields, and those additions were ignored.
What was supposed to happen?
These fields should be merged/added to the base config at runtime.
Platform
Steam
Mods
Logs
No response
The text was updated successfully, but these errors were encountered: