Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Shadows #686

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Fix Shadows #686

merged 9 commits into from
Aug 8, 2023

Conversation

JohnCorby
Copy link
Member

@JohnCorby JohnCorby commented Aug 7, 2023 •
edited
Loading

Major features

Minor features

Improvements

Bug fixes

  • Shadows glitch out way less
    • Custom planets now can have better, longer shadows (using ProxyShadowCaster and ProxyShadowCasterGroup from existing details and in bundles)
    • Shadows no longer jitter
    • Note: short-distance shadows still cast from planets behind suns. However, this also happens in vanilla, so it is not fixed here

@JohnCorby JohnCorby changed the base branch from archaeologist-achievement-for-addons to dev August 7, 2023 06:05
@JohnCorby JohnCorby marked this pull request as draft August 7, 2023 06:05
@JohnCorby JohnCorby marked this pull request as ready for review August 7, 2023 06:30
@JohnCorby JohnCorby requested a review from xen-42 August 7, 2023 20:38
@JohnCorby JohnCorby changed the title Fix Proxy Shadows Fix Shadowing Aug 8, 2023
@JohnCorby JohnCorby changed the title Fix Shadowing Fix Shadows Aug 8, 2023
@JohnCorby JohnCorby marked this pull request as draft August 8, 2023 01:52
xen-42
xen-42 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@xen-42 xen-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yessir miller

@JohnCorby JohnCorby marked this pull request as ready for review August 8, 2023 02:21
@JohnCorby JohnCorby merged commit fea1528 into dev Aug 8, 2023
2 checks passed
@JohnCorby JohnCorby deleted the fix-proxy-shadows branch August 8, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xen-42 xen-42 xen-42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnCorby @xen-42