Sort countries alphabeitcally in the AP settings #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the country list for the wireless AP settings so they are always sorted alphabetically, taking into account i18n. The sorting is done using locale.strcoll as the comparison function so reasonably correct sorting is expected for various languages. Because we are wrapping the sorting code in bottle_utils.lazy.Lazy, the null-value item is set using empty_value kwarg, which requires Othernet-Project/librarian#340 to be merged. Signed-off-by: Branko Vukelic <branko@outernet.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the country list for the wireless AP settings so they are
always sorted alphabetically, taking into account i18n. The sorting is done
using locale.strcoll as the comparison function so reasonably correct
sorting is expected for various languages.
Because we are wrapping the sorting code in bottle_utils.lazy.Lazy, the
null-value item is set using empty_value kwarg, which requires
Othernet-Project/librarian#340 to be merged.
Fixes #6