Switch default protocol from 4 (SIGS) to 3 (serial) #23
Conversation
|
This project's history also shows a bit of bouncing between buttons (back in 2008, during initial release): Initial import. Used a hardcoded value for Serial, with a comment initially saying SIGS, but corrected to say Serial (2008-09-27): The project was given a default The project default was moved from Serial to SIGS (2008-10-13): From the other thread, here's some history of the project bouncing between buttons: The module loader op2ext was upgraded to support outpost2.ini modules, and NetFix was added (using Serial) (2008-10-13): The SIGS button was renamed O2Net and used for NetFix (2010-12-25): The Serial button was renamed and NetFix was moved back to it (2015-01-31): In terms of the resource edits, the menu resource is stored in The menu resources were edited in 2015, in SVN revision 913, which removed, renamed, and re-positioned buttons, and moved NetFix from SIGS to Serial. The menu resources can be edited with Resource Hacker. The (The "O2Net" rename was done with a hex editor, so there was careful attention to choose a name that didn't change the string size beyond what padding allowed). I see two options for resolving the discrepancy between the standard I might need a couple days to distance myself from this. |
|
It sounds like editing the resource is easy and allows flexibility in the number of characters used to represent the button's title, so I might tend to prefer this for ease of use. It also doesn't involve any memory editing, which appeals to me. Although I don't have a strong preference either way. Thanks for putting the research in on what is going on. -Brett |
|
I'd like to merge this branch as a bug fix for the current NetFixClient implementation and move the discussion on long term implementation to an issue. |
|
I suppose I have been dragging my feet about addressing this. My inclination is to discard this change, as it moves the code further from what was intended. Additionally, it doesn't really "fix" anything, as in game behaviour remains unchanged. Rather it makes the code more consistent with another change, which I considered undesirable. With that said, this is a fairly minor change, and I'm likely being a bit irrational about it. I just tried exporting a .rc file with Resource Hacker, and ran a diff of the two versions. The menu changes were fairly minor, though there are more changes overall than I expected. Seems a number of the bitmap resources have changed. No time to look into it right now. It's just occurring to me we have no official place to track long term changes to projects which haven't moved to GitHub. |
Remove extern call on logFile
|
I played with this for a while. The old dialog looks as below. I can paste the old script into dialog 259 and it works with Outpost 2. Unfortunately, SIGS is grayed out. I think something outside of Dialog 259 is forcing the SIGS option to be disabled, but I'm unsure of the source. This would need to be tackled before the SIGS button could be restored and repurposed.
I do not see what below would cause the button to be disabled |
|
From what I remember, it was disabled by editing the resource. It's been a while though. I wonder if there is a way to restore the resource from an older version. |
Split from Pull Request #19, which contains a bit of history about which button was used.