Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add 0x16 example lines to unit tests #172

Merged
merged 1 commit into from
Jul 15, 2024
Merged

util: add 0x16 example lines to unit tests #172

merged 1 commit into from
Jul 15, 2024

Conversation

wexxlee
Copy link
Collaborator

@wexxlee wexxlee commented Jun 22, 2024

Closes #158

@wexxlee wexxlee enabled auto-merge (squash) June 22, 2024 19:39
@github-actions github-actions bot added auto-merge PR will be auto-merged upon approving review util /util test /test, /ui/test needs-review Awaiting review and removed auto-merge PR will be auto-merged upon approving review labels Jun 22, 2024
@wexxlee wexxlee added the auto-merge PR will be auto-merged upon approving review label Jun 22, 2024
@wexxlee wexxlee requested a review from valarnin July 15, 2024 22:35
@wexxlee
Copy link
Collaborator Author

wexxlee commented Jul 15, 2024

@valarnin Since you reviewed the broader refactoring on the example log lines, would you mind giving this a review too?

valarnin
valarnin approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@valarnin valarnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wexxlee wexxlee merged commit 7009508 into OverlayPlugin:main Jul 15, 2024
14 checks passed
@github-actions github-actions bot removed the needs-review Awaiting review label Jul 15, 2024
github-actions bot pushed a commit that referenced this pull request Jul 15, 2024
gh-pages build: util: add 0x16 example lines to unit tests (#172)
90569bb 
Closes #158 7009508
@wexxlee wexxlee deleted the add-0x16-test-lines branch July 16, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valarnin valarnin valarnin approved these changes

Assignees
No one assigned
Labels
auto-merge PR will be auto-merged upon approving review test /test, /ui/test util /util
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 0x16 example lines to regex/netregex unit testing
2 participants
@wexxlee @valarnin