jobs: add pct job details struct #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugin
wexxlee
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Thanks for this! I'm working on other stuff before I get PCT fully leveled, so I won't be able to test this for a bit either. But the struct looks right to me.
Minor formatting/prop change requested, and a purely optional stylistic suggestion (take it or leave it as you see fit).
26 tasks
Co-authored-by: Wexx <86693821+wexxlee@users.noreply.github.com>
github-actions
bot
added
the
auto-merge
MaikoTan
commented
Jul 5, 2024
wexxlee
approved these changes
Jul 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
Didn't test, i don't know about OP.... --------- Co-authored-by: Wexx <86693821+wexxlee@users.noreply.github.com> 4aba68f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't test, i don't know about OP....
EDIT: I try be best, created a PR at the OP side: OverlayPlugin/OverlayPlugin#372