Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is in its current form completely untested!
As announced in #19, this should fix all odd naming issues.
The main logic is in:
getTitledVillagerName
for getting the name in the "Forename <Surname> <the Title>" schema, depending on the config.parseFullName
,parseForename
andparseSurname
to get the components from an existing name again.There's no
create
name methods anymore, onlyupdate
methods, which take everything into account.