-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base theme updates #194
Merged
Merged
Base theme updates #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoZivk
previously approved these changes
May 21, 2024
jwass
previously approved these changes
May 21, 2024
skmoore
requested changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add height, est_height, min_height, diameter_crown, leaf_type, leaf_cycle, taxon, taxon:species, taxon:cultivar, and denotation. We currently use all of these tags to create our 3d trees layer from Daylight.
jwass
approved these changes
May 22, 2024
DavidKarlas
approved these changes
May 22, 2024
TristanDiet-TomTom
approved these changes
May 22, 2024
vcschapp
approved these changes
May 22, 2024
skmoore
approved these changes
May 22, 2024
vcschapp
pushed a commit
that referenced
this pull request
Jun 12, 2024
* Add genus/species to land * Map OSM tags['layer'] to Overture's level * Add rest of tags to source_tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more OSM tags — species, genus to the
source_tags
for theland
type which includes trees.Adds OSM's layer tag as Overture's
level
tag.Reference
Testing
Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.
TODO.
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.