Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base theme updates #194

Merged
merged 3 commits into from
May 22, 2024
Merged

Base theme updates #194

merged 3 commits into from
May 22, 2024

Conversation

jenningsanderson
Copy link
Collaborator

@jenningsanderson jenningsanderson commented May 21, 2024

Description

Adds more OSM tags — species, genus to the source_tags for the land type which includes trees.

Adds OSM's layer tag as Overture's level tag.

Reference

Testing

Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.

TODO.

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. [N/A] Add relevant examples.
  2. [N/A] Add relevant counterexamples.
  3. [N/A] Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. [N/A] Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. [N/A] Update Docusaurus documentation, if an update is required.
  6. [N/A] Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

BoZivk
BoZivk previously approved these changes May 21, 2024
@jenningsanderson jenningsanderson changed the title Add genus/species to land Base theme updates May 21, 2024
jwass
jwass previously approved these changes May 21, 2024
Copy link
Contributor

@skmoore skmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add height, est_height, min_height, diameter_crown, leaf_type, leaf_cycle, taxon, taxon:species, taxon:cultivar, and denotation. We currently use all of these tags to create our 3d trees layer from Daylight.

@vcschapp vcschapp self-requested a review May 22, 2024 15:35
@TristanDiet-TomTom TristanDiet-TomTom requested review from TristanDiet-TomTom and removed request for vcschapp May 22, 2024 15:35
@vcschapp vcschapp self-requested a review May 22, 2024 15:35
@vcschapp vcschapp requested a review from skmoore May 22, 2024 15:36
@vcschapp vcschapp merged commit 07d6c2e into dev May 22, 2024
2 checks passed
@vcschapp vcschapp deleted the add-base-details branch May 22, 2024 16:27
vcschapp pushed a commit that referenced this pull request Jun 12, 2024
* Add genus/species to land

* Map OSM tags['layer'] to Overture's level

* Add rest of tags to source_tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants