Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFMPEG merging for better quality #59

Closed
Owez opened this issue Jan 6, 2023 · 1 comment
Closed

FFMPEG merging for better quality #59

Owez opened this issue Jan 6, 2023 · 1 comment
Assignees
@Owez
Labels
enhancement New feature or request

Comments

@Owez
Copy link
Owner

Owez commented Jan 6, 2023 •
edited

Right now Yark is unfortunately limited to 720p videos at most because YouTube only has videos with video + audio combined at this resolution. To download at 1080p or higher (2k/4k videos), an FFMPEG merging solution needs to be implemented to pull seperate audio and video from YouTube, and then combine them.

This issue stems from #55 and #58, it'll be part of the upcoming Yark 1.3 as a major fix.

This issue was a red herring; there's now much nicer support for better quality videos and documentation to support users using FFmpeg but people could always download high quality videos; it turns out I didn't have FFmpeg installed properly during testing
@Owez Owez added the enhancement New feature or request label Jan 6, 2023
This was referenced Jan 6, 2023
Closed
Closed
Merged
@Owez
Copy link
Owner Author

Owez commented Jan 9, 2023

Closed by #66

@Owez Owez closed this as completed Jan 9, 2023
@Owez Owez self-assigned this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Owez Owez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Owez