Add format config option and improve download reliability #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owez
added
bug
|
Credited wrong person 💀 |
Ahh my bad haha |
|
Hah no worries |
|
The upcoming changes could simplify a lot of this yt-dlp/yt-dlp#4846 |
Owez
force-pushed
the
55-use-a-format-fallback-or-allow-to-manually-set-the-video-format
branch
from
d0090ba
to
092dee0
Compare
|
Sorry about the mess, removing changes and resetting to current origin/master |
|
New
I don't want to try to download 480/360p quality videos even if its a possible mitigation. Might add a warning to say "FFMPEG is reccomended" if it's not installed at startup (and add docs to README) to solve #59 because the format quality issues have been resolved here. |
|
Superceded by #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @alexislours* for the initial issue and research. This may be extended in Yark 1.3 or beyond with an FFMPEG merging solution to get and merge the highest-quality files from YouTube into a video. For now, this PR serves as a patch to fix issues from yt-dlp/yt-dlp#3372 and add some customization to downloading.