Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proxy support to refresh #79

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Added proxy support to refresh #79

merged 3 commits into from
Jan 13, 2023

Conversation

na4ma4
Copy link

@na4ma4 na4ma4 commented Jan 12, 2023

Some channels require proxies to download from other regions, this adds --proxy to the refresh command.

@na4ma4 na4ma4 mentioned this pull request Jan 12, 2023
@na4ma4
Copy link
Author

na4ma4 commented Jan 12, 2023

There was some debug code that caused the command to fail during normal operation, I commented that out as well.

Loading channel.test archive..
Automatically migrating archive from v3 to v4, a backup has been made at channel.test/yark.bak
Downloading metadata..
Traceback (most recent call last):
  File "/usr/bin/yark", line 8, in <module>
    sys.exit(_cli())
  File "/usr/lib/python3.10/site-packages/yark/cli.py", line 148, in _cli
    archive.metadata(config)
  File "/usr/lib/python3.10/site-packages/yark/archive.py", line 164, in metadata
    with open("demo/dump.json", "w+") as file:
FileNotFoundError: [Errno 2] No such file or directory: 'demo/dump.json'

Copy link
Owner

@Owez Owez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting, solid PR :)

yark/archive.py Outdated Show resolved Hide resolved
@Owez Owez changed the title added proxy support to refresh Added proxy support to refresh Jan 12, 2023
@Owez Owez self-assigned this Jan 12, 2023
@Owez Owez added the enhancement New feature or request label Jan 12, 2023
@Owez Owez merged commit c4fca9c into Owez:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants