Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domain from esx name #72

Merged
merged 3 commits into from
Sep 3, 2018
Merged

Conversation

MicKBfr
Copy link
Contributor

@MicKBfr MicKBfr commented Apr 6, 2018

Domain in esx name can be a problem with influxgraph and grafana.

 Domain in esx name can be a problem with influxgraph and grafana.
@sofixa
Copy link
Member

sofixa commented Apr 6, 2018

Hi, @MicKBfr . This would be a breaking change and can make for some weirdness, so could you please make it optional (with a flag in the config file, like the one for domain)?

Adrian

@MicKBfr
Copy link
Contributor Author

MicKBfr commented Apr 10, 2018

OK, i will try to make it optional.
Any idea for flag name ? RemoveDomainHostName ?
Thanks

@sofixa
Copy link
Member

sofixa commented Apr 10, 2018

@MicKBfr i think something more like RemoveDomainFromHostName or RemoveHostDomainName , however unappealing, might be more obvious.

Adrian

@MicKBfr
Copy link
Contributor Author

MicKBfr commented Apr 13, 2018

Hi Adrian,
I have made some change to make it optional, but i'm not a good dev...
I have compilation problem from my docker with master version. I have already made container previously without problem

Step 3 : RUN go get -u github.com/vmware/govmomi && go get -u github.com/influxdata/influxdb/client/v2 && go get github.com/Oxalide/vsphere-influxdb-go

github.com/Oxalide/vsphere-influxdb-go

src/github.com/Oxalide/vsphere-influxdb-go/vsphere-influxdb.go:473: device.Backing undefined (type types.BaseVirtualDevice has no field or method Backing)
src/github.com/Oxalide/vsphere-influxdb-go/vsphere-influxdb.go:477: device.diskObjectId undefined (type types.BaseVirtualDevice has no field or method diskObjectId)
src/github.com/Oxalide/vsphere-influxdb-go/vsphere-influxdb.go:477: device.Backing undefined (type types.BaseVirtualDevice has no field or method Backing)
The command '/bin/sh -c go get -u github.com/vmware/govmomi && go get -u github.com/influxdata/influxdb/client/v2 && go get github.com/Oxalide/vsphere-influxdb-go' returned a non-zero code: 2

Have you a idea?
Thanks
Mickael

@sofixa
Copy link
Member

sofixa commented Apr 25, 2018

@MicKBfr yeah, sorry about that, master is currently broken (hadn't had the time to fix it yet), you should build with the latest stable tag.

Adrian

@jorioux
Copy link

jorioux commented Aug 10, 2018

@sofixa I would really appreciate if you could merge this pull into master and build the rpm. The last binaries are quite old.

@sofixa sofixa merged commit 639ef28 into Oxalide:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants