Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist resorting #446

Closed
OxygenCobalt opened this issue May 21, 2023 · 11 comments
Closed

Playlist resorting #446

OxygenCobalt opened this issue May 21, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request music Related to music loading

Comments

@OxygenCobalt
Copy link
Owner

Split from #36.

@OxygenCobalt OxygenCobalt added enhancement New feature or request music Related to music loading labels May 21, 2023
@OxygenCobalt OxygenCobalt self-assigned this May 21, 2023
@OxygenCobalt OxygenCobalt mentioned this issue May 21, 2023
@madenerrgy
Copy link

@OxygenCobalt that's normal?

Maybe make a pop-up window where it will say "These tracks are already in this playlist" ?

VID_20230524_140307_853.mp4

@OxygenCobalt
Copy link
Owner Author

OxygenCobalt commented May 24, 2023

The issue is that I don't know how to indicate a track selection being partially present in a playlist @madenerrgy. Do you have any ideas? I do like the dialog idea.

@madenerrgy
Copy link

The issue is that I don't know how to indicate a track selection being partially present in a playlist @madenerrgy. Do you have any ideas? I do like the dialog idea.

Hm..
Maybe make an implementation like in spotify? Or is it hard to do for local tracks?

As an example, you can check by the file name, and if the file is added to the playlist again, then that's when a warning pop-up window will appear.

What do you think, Alexander, is it possible to do this?
Sorry for my English, I'm using translator :)

@OxygenCobalt
Copy link
Owner Author

Oh no, it's trivial to do what you're asking. I think I can indicate whether "part of the selection is in the playlist" or if "all of the selection is in the playlist" in a hypothetical dialog @madenerrgy.

@madenerrgy
Copy link

Oh no, it's trivial to do what you're asking. I think I can indicate whether "part of the selection is in the playlist" or if "all of the selection is in the playlist" in a hypothetical dialog @madenerrgy.

Yes, you can do that, but I don't know how to implement it correctly :(

@OxygenCobalt
Copy link
Owner Author

You don't need to worry about it, I'll be able to work on it myself @madenerrgy.

@madenerrgy
Copy link

You don't need to worry about it, I'll be able to work on it myself @madenerrgy.

Thanks, pro!
Your work really makes us happy ;)

@madenerrgy
Copy link

madenerrgy commented May 31, 2023

You don't need to worry about it, I'll be able to work on it myself @madenerrgy.

Hi Alexander!
One more question, look, if you add a track to the playlist and go to the add menu again, then we see a “tick” that it has already been added, but if you click on this tick again - track is not deleted, but instead added again to playlist.

I think this is a bit illogical behavior, I hope you understand what I'm talking about :)

Screenshot_20230531-070811_Auxio

@OxygenCobalt
Copy link
Owner Author

That behavior makes no sense @madenerrgy, in my opinion. It's not a selection, and having a dialog called "add to playlist" remove a track is extremely unfriendly

@illdeletethis
Copy link

how do i remove a track from a playlist or the queue?

@OxygenCobalt
Copy link
Owner Author

You can swipe an item to the left to remove it @illdeletethis. I am considering indicating this behavior later with #479.

OxygenCobalt added a commit that referenced this issue Jul 26, 2023
Add the ability to resort a playlist when in edit mode.

Resolves #446.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request music Related to music loading
Projects
None yet
Development

No branches or pull requests

3 participants