Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this is bad #1

Open
Oxymoron290 opened this issue Aug 11, 2022 · 1 comment
Open

this is bad #1

Oxymoron290 opened this issue Aug 11, 2022 · 1 comment
Assignees
@Oxymoron290

Comments

@Oxymoron290
Copy link
Owner

Oxymoron290 commented Aug 11, 2022 •
edited
Loading

ASP.NET-Core-Linux-Container-Example/CohoWineryAPI/Program.cs

Line 19 in 8794f99

System.Threading.Thread.Sleep(10000);

Use a Readiness Health Probe instead. Kubernetes has a command style health probe that can be used. Documentation

https://www.cyberciti.biz/faq/bash-get-exit-code-of-command/
@Oxymoron290 Oxymoron290 self-assigned this Aug 11, 2022
Oxymoron290 added a commit that referenced this issue Aug 18, 2022
@Oxymoron290
#1 - remove naughty work around
f9e0c44
Oxymoron290 added a commit that referenced this issue Aug 18, 2022
@Oxymoron290
#1 - potential solution to ensure authentication before startup
31c693a
Oxymoron290 added a commit that referenced this issue Aug 18, 2022
@Oxymoron290
#1 - correct condition
a6c8fee
Oxymoron290 added a commit that referenced this issue Aug 18, 2022
@Oxymoron290
#1 - re-add conditional to ensure success
61aa610
@Oxymoron290
Copy link
Owner Author

Potentially fixed, please review.

Oxymoron290 added a commit that referenced this issue Nov 9, 2022
@Oxymoron290
#1 - remove naughty work around
77607f6
Oxymoron290 added a commit that referenced this issue Nov 9, 2022
@Oxymoron290
#1 - potential solution to ensure authentication before startup
f524236
Oxymoron290 added a commit that referenced this issue Nov 9, 2022
@Oxymoron290
#1 - correct condition
3f05ca3
Oxymoron290 added a commit that referenced this issue Nov 9, 2022
@Oxymoron290
#1 - re-add conditional to ensure success
a93eb27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Oxymoron290 Oxymoron290

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Oxymoron290