Add default classpath to enable type resolution #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesigl
force-pushed
the
Add-classpath-default
branch
from
2d0e0d7
to
82d0ace
Compare
added 2 commits
July 23, 2022 14:03
sesigl
force-pushed
the
Add-classpath-default
branch
from
82d0ace
to
6740e88
Compare
sesigl
commented
Jul 23, 2022
| @@ -15,18 +16,29 @@ import java.nio.file.Paths | |||
| threadSafe = true, | |||
| requiresDependencyCollection = ResolutionScope.TEST) | |||
| class CheckMojo : DetektMojo() { | |||
| lateinit var cliArgs: CliArgs | |||
There was a problem hiding this comment.
set to a field for testing purposes. Maybe there is another smart idea of how we can assert the expected outcome.
| class CheckMojoSpec : Spek({ | ||
| val invalidPackageNamingDirectoryPath by lazy { |
There was a problem hiding this comment.
Extracted a test factors to separate concerns, reduce duplication and improve readability
| @@ -0,0 +1 @@ | |||
| package `code-samples`.`valid` | |||
There was a problem hiding this comment.
Created a valid input to execute a full testrun. Maybe this is not necessary - not sure.
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
============================================
+ Coverage 75.17% 75.33% +0.16%
- Complexity 22 31 +9
============================================
Files 8 8
Lines 145 150 +5
Branches 37 38 +1
============================================
+ Hits 109 113 +4
+ Misses 12 11 -1
- Partials 24 26 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.