Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump detekt.version from 1.22.0 to 1.23.0 #194

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 25, 2023

Bumps detekt.version from 1.22.0 to 1.23.0.
Updates detekt-tooling from 1.22.0 to 1.23.0

Release notes

Sourced from detekt-tooling's releases.

v1.23.0

We're so proud to announce the next upcoming stable release of detekt: 1.23.0 🚀 This release is coming with 25 new rules and much more.

We moved the detekt-compiler-plugin to the main repo, and you can now use it in your builds following the official documentation.

This release also marks the beginning of development of 2.x from the main branch! You can follow the progress here

We want to take the opportunity to thank our Sponsors and our Contributors for testing, bug reporting and helping us release this new version of Detekt. You're more than welcome to join our community on the #detekt channel on KotlinLang's Slack (you can get an invite here).

Notable Changes
  • This is the first version of Detekt that ships with the detekt-compiler-plugin. The Detekt Compiler plugin is still experimental, but we're moving it closer to Detekt to make it easier to integrate. From now on the compiler plugin will follow the same versioning schema as Detekt. We invite you to try it and provide feedback till we stabilize it. You can read more about it in the official documentation page - #5492
  • We added 25 new Rules to detekt
    • BracesOnIfStatements - #5700
    • BracesOnWhenStatements - #5838
    • CastNullableToNonNullableType - #5653
    • DoubleNegativeLambda - #5937
    • ForbiddenAnnotation - #5515
    • PropertyUsedBeforeDeclaration - #6062
    • StringShouldBeRawString - #5705
    • SuspendFunSwallowedCancellation - #5666
    • UnusedParameter - #5722
    • UnusedPrivateProperty - #5722
    • UseLet - #6091
    • UnnecessaryBracesAroundTrailingLambda - #6029
    • Plus the bump to KtLint 0.49.1 added the following rules to the detekt-formatting ruleset:
      • ClassName - #6037
      • EnumWrapping - #6028
      • FunctionName - #6037
      • IfElseBracing - #6028
      • IfElseWrapping - #6028
      • MultilineExpressionWrapping - #6028
      • NoBlankLineInList - #6028
      • NoConsecutiveComments - #6028
      • NoEmptyFirstLineInClassBody - #6028
      • NoSingleLineBlockCommentRule - #6104
      • ParameterWrapping - #6028
      • PropertyName - #6037
      • PropertyWrapping - #6028
      • StringTemplateIndent - #6028
      • TryCatchFinallySpacing - #6028
  • Notable changes to existing rules:
    • UnnecessaryAbstractClass now only runs with type resolution - #5829
    • UnusedPrivateMember has been refactored with some of its logic moved to UnusedParameter and UnusedPrivateProperty - #5722
    • Removed the ignoreOverridden config from BooleanPropertyNaming, ConstructorParameterNaming, FunctionNaming, VariableNaming and FunctionParameterNaming as not useful for those rules - #5718
    • Added ignoredSubjectTypes to rule ElseCaseInsteadOfExhaustiveWhen to specify types that should be ignored by the rule (#5623) - #5634
    • Added allowOperators to rule DataClassContainsFunctions - #5658
    • MandatoryBracesIfStatements has been removed in favor of BracesOnIfStatements - #5700
    • Added ignoreWhenContainingVariableDeclaration to UseIfInsteadOfWhen to ignore captured variables - #5681

... (truncated)

Commits
  • ad80630 Prepare Detekt 1.23.0 (#6120)
  • f3f0ce4 Replace sarif4k usage with Groovy JSON from gradleApi() in detekt-gradle-plug...
  • e65ef3b Add comments with a list of regexes to ForbiddenComment (#5981)
  • 67d2c72 Reduce LoopWithTooManyJumpStatements finding scope (#6110)
  • f99ac58 SerialVersionUIDInSerializableClass - Update the error location (#6114)
  • 93de544 Inline Cases enum and inline other external test code into the test classes (...
  • 940af07 New wrapped ktlint rule NoSingleLineBlockCommentRule (#6104)
  • 20853fc Changed TwitterCompose ruleset to maintained version (#6108)
  • d807375 Update dependency io.github.detekt.sarif4k:sarif4k to v0.4.0 (#6113)
  • 01fa957 Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v0.49.1 (#6...
  • Additional commits viewable in compare view

Updates detekt-cli from 1.22.0 to 1.23.0

Release notes

Sourced from detekt-cli's releases.

v1.23.0

We're so proud to announce the next upcoming stable release of detekt: 1.23.0 🚀 This release is coming with 25 new rules and much more.

We moved the detekt-compiler-plugin to the main repo, and you can now use it in your builds following the official documentation.

This release also marks the beginning of development of 2.x from the main branch! You can follow the progress here

We want to take the opportunity to thank our Sponsors and our Contributors for testing, bug reporting and helping us release this new version of Detekt. You're more than welcome to join our community on the #detekt channel on KotlinLang's Slack (you can get an invite here).

Notable Changes
  • This is the first version of Detekt that ships with the detekt-compiler-plugin. The Detekt Compiler plugin is still experimental, but we're moving it closer to Detekt to make it easier to integrate. From now on the compiler plugin will follow the same versioning schema as Detekt. We invite you to try it and provide feedback till we stabilize it. You can read more about it in the official documentation page - #5492
  • We added 25 new Rules to detekt
    • BracesOnIfStatements - #5700
    • BracesOnWhenStatements - #5838
    • CastNullableToNonNullableType - #5653
    • DoubleNegativeLambda - #5937
    • ForbiddenAnnotation - #5515
    • PropertyUsedBeforeDeclaration - #6062
    • StringShouldBeRawString - #5705
    • SuspendFunSwallowedCancellation - #5666
    • UnusedParameter - #5722
    • UnusedPrivateProperty - #5722
    • UseLet - #6091
    • UnnecessaryBracesAroundTrailingLambda - #6029
    • Plus the bump to KtLint 0.49.1 added the following rules to the detekt-formatting ruleset:
      • ClassName - #6037
      • EnumWrapping - #6028
      • FunctionName - #6037
      • IfElseBracing - #6028
      • IfElseWrapping - #6028
      • MultilineExpressionWrapping - #6028
      • NoBlankLineInList - #6028
      • NoConsecutiveComments - #6028
      • NoEmptyFirstLineInClassBody - #6028
      • NoSingleLineBlockCommentRule - #6104
      • ParameterWrapping - #6028
      • PropertyName - #6037
      • PropertyWrapping - #6028
      • StringTemplateIndent - #6028
      • TryCatchFinallySpacing - #6028
  • Notable changes to existing rules:
    • UnnecessaryAbstractClass now only runs with type resolution - #5829
    • UnusedPrivateMember has been refactored with some of its logic moved to UnusedParameter and UnusedPrivateProperty - #5722
    • Removed the ignoreOverridden config from BooleanPropertyNaming, ConstructorParameterNaming, FunctionNaming, VariableNaming and FunctionParameterNaming as not useful for those rules - #5718
    • Added ignoredSubjectTypes to rule ElseCaseInsteadOfExhaustiveWhen to specify types that should be ignored by the rule (#5623) - #5634
    • Added allowOperators to rule DataClassContainsFunctions - #5658
    • MandatoryBracesIfStatements has been removed in favor of BracesOnIfStatements - #5700
    • Added ignoreWhenContainingVariableDeclaration to UseIfInsteadOfWhen to ignore captured variables - #5681

... (truncated)

Commits
  • ad80630 Prepare Detekt 1.23.0 (#6120)
  • f3f0ce4 Replace sarif4k usage with Groovy JSON from gradleApi() in detekt-gradle-plug...
  • e65ef3b Add comments with a list of regexes to ForbiddenComment (#5981)
  • 67d2c72 Reduce LoopWithTooManyJumpStatements finding scope (#6110)
  • f99ac58 SerialVersionUIDInSerializableClass - Update the error location (#6114)
  • 93de544 Inline Cases enum and inline other external test code into the test classes (...
  • 940af07 New wrapped ktlint rule NoSingleLineBlockCommentRule (#6104)
  • 20853fc Changed TwitterCompose ruleset to maintained version (#6108)
  • d807375 Update dependency io.github.detekt.sarif4k:sarif4k to v0.4.0 (#6113)
  • 01fa957 Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v0.49.1 (#6...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `detekt.version` from 1.22.0 to 1.23.0.

Updates `detekt-tooling` from 1.22.0 to 1.23.0
- [Release notes](https://github.com/detekt/detekt/releases)
- [Commits](detekt/detekt@v1.22.0...v1.23.0)

Updates `detekt-cli` from 1.22.0 to 1.23.0
- [Release notes](https://github.com/detekt/detekt/releases)
- [Commits](detekt/detekt@v1.22.0...v1.23.0)

---
updated-dependencies:
- dependency-name: io.gitlab.arturbosch.detekt:detekt-tooling
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.gitlab.arturbosch.detekt:detekt-cli
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 25, 2023
@dependabot dependabot bot requested a review from Ozsie May 25, 2023 04:58
@codecov-commenter
Copy link

Codecov Report

Merging #194 (50b3c30) into main (d99cd32) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##               main     #194   +/-   ##
=========================================
  Coverage     73.93%   73.93%           
  Complexity       37       37           
=========================================
  Files             9        9           
  Lines           165      165           
  Branches         39       39           
=========================================
  Hits            122      122           
  Misses           17       17           
  Partials         26       26           

@dmitry-weirdo
Copy link

I hope that the plugin version will also be updated to 1.23.0, to conform with the detekt version.

@Ozsie
Copy link
Owner

Ozsie commented May 26, 2023

I hope that the plugin version will also be updated to 1.23.0, to conform with the detekt version.

It will be, I have just not had the opportunity to go through any potential changes that needs to be done in this end

@Ozsie Ozsie merged commit f6936fb into main Jun 19, 2023
15 checks passed
@dependabot dependabot bot deleted the dependabot/maven/detekt.version-1.23.0 branch June 19, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants