Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ALIGN macro #206

Merged
merged 1 commit into from Apr 24, 2017
Merged

Conversation

WOnder93
Copy link
Contributor

The 'ALIGN' macro defined in core.h is not used anywhere, so it can be removed.

The 'ALIGN' macro defined in core.h is not used anywhere, so it can be
removed.
@codecov-io
Copy link

codecov-io commented Apr 23, 2017

Codecov Report

Merging #206 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   67.85%   67.93%   +0.08%     
==========================================
  Files           9        9              
  Lines        1014     1023       +9     
  Branches      167      167              
==========================================
+ Hits          688      695       +7     
- Misses        246      248       +2     
  Partials       80       80
Impacted Files Coverage Δ
src/core.c 64.62% <0%> (-0.09%) ⬇️
src/opt.c 92.94% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eea010...7c57b3f. Read the comment docs.

@josephlr
Copy link
Contributor

It looks like this used to be used to align the block struct, so it would have a 128 bit alignment. This is because the optimized implementation would consider a block as an array of __m128i. But this was broken anyway because the memory allocator does not give the proper 128-bit alignment. I say remove the macro and deal with the alignment issues later.

@sneves sneves merged commit 30c78a1 into P-H-C:master Apr 24, 2017
@sneves
Copy link
Contributor

sneves commented Apr 24, 2017

Alright, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants