bump ABI version #236
Merged
bump ABI version #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before commit 5e78398 (Added ABI Version Number, and properly handle it for Linux and Darwin) the library was installed as `libargon2.so`, though the soname was `libargon2.so.0`. Actually installing a package with that file makes `ldconfig` create a symbolic link matching the soname. That file does not belong to the package and is not managed by the package manager. Building a package from current git master results in the library file `libargon2.so.0` being included in the package. That conflicts with the file formerly created by `ldconfig`. So bump the ABI version for a conflict-free transition to current code.
|
Now that we have |
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 67.46% 76.85% +9.38%
==========================================
Files 9 9
Lines 959 959
Branches 167 167
==========================================
+ Hits 647 737 +90
Misses 222 222
+ Partials 90 0 -90
Continue to review full report at Codecov.
|
Closed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before commit 5e78398 (Added ABI Version Number, and properly handle
it for Linux and Darwin) the library was installed as
libargon2.so,though the soname was
libargon2.so.0. Actually installing a packagewith that file makes
ldconfigcreate a symbolic link matching thesoname. That file does not belong to the package and is not managed by
the package manager.
Building a package from current git master results in the library file
libargon2.so.0being included in the package. That conflicts with thefile formerly created by
ldconfig.So bump the ABI version for a conflict-free transition to current code.