fix(runtime): invalid splice in ownKeys trap

P0lip · May 15, 2022 · 1953000 · 1953000
1 parent 3ffbc62
commit 1953000
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nimma",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Scalable JSONPath engine.",
   "keywords": [
     "json",

diff --git a/src/__tests__/index.test.mjs b/src/__tests__/index.test.mjs
@@ -1114,6 +1114,41 @@ describe('Nimma', () => {
     });
   });
 
+  it('works #35', () => {
+    const document = {
+      definitions: {
+        propA: {
+          properties: {
+            a: {},
+          },
+        },
+        propB: {
+          allOf: [
+            {
+              properties: {
+                b: {},
+              },
+            },
+          ],
+        },
+      },
+    };
+
+    const collected = collect(document, [
+      '$.definitions.*.properties',
+      '$.definitions.*.allOf.*.properties',
+    ]);
+
+    expect(collected).to.deep.eq({
+      '$.definitions.*.properties': [
+        [{ a: {} }, ['definitions', 'propA', 'properties']],
+      ],
+      '$.definitions.*.allOf.*.properties': [
+        [{ b: {} }, ['definitions', 'propB', 'allOf', 0, 'properties']],
+      ],
+    });
+  });
+
   forEach([
     Object.preventExtensions({
       shirts: Object.seal({

diff --git a/src/runtime/traverse.mjs b/src/runtime/traverse.mjs
@@ -115,9 +115,12 @@ const traps = {
 
     const actualKeys = Object.keys(stored);
 
-    for (const key of actualKeys) {
+    for (let i = 0; i < actualKeys.length; i++) {
+      const key = actualKeys[i];
+
       if (!Object.hasOwnProperty.call(target, key)) {
-        actualKeys.splice(actualKeys.indexOf(key), 1);
+        actualKeys.splice(i, 1);
+        i--;
         continue;
       }