Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pyramid PQ #221

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Added Pyramid PQ #221

wants to merge 16 commits into from

Conversation

Silwhoon
Copy link

I will need a lot of feedback for this change - it's quite a big one! ANY feedback/suggestions big or small are much appreciated.

  • Added PyramidPQ solo & party handling
  • Added Pharaoh's Blessing buff handling.. but the BERSERK buffstat seems to be bugged? It makes the player attack very slowly and does not grant any additional damage.
  • Added Rage of Pharaoh skill handling
  • Added GMS-like text & effects wherever possible. There are a few missing texts that I have labelled with a "TODO"
  • Added GMS-like PQ handling wherever possible. Mob Respawn is not completely GMS-like. These have also been labelled with a "TODO"
  • Added Bonus Stage handling - Including the 'skipping' functionality, drops & a fix to ItemRewardHandler
  • Added handling for the Medal Quest.. but it seems that saving quest infoNumber progress is bugged..? Didn't want to address that in this PR

@Silwhoon Silwhoon marked this pull request as draft February 10, 2024 16:48
@Silwhoon Silwhoon marked this pull request as ready for review February 10, 2024 17:10
@P0nk
Copy link
Owner

P0nk commented Feb 23, 2024

Appreciate the effort! Looks good on first glance apart from putting a bit too much into Character.java (which I'm trying to pick apart to make it less of a god object).
I'll have a closer look once I got more times on my hands. I hope you don't mind waiting for a review a while longer.

@Silwhoon
Copy link
Author

I have no issues with waiting however long you need. I will amend the code and try to reduce the code put into Character.java in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants