Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Periods in class selectors are not supported #33

Closed
firstinflight opened this issue Apr 14, 2014 · 1 comment
Closed

Periods in class selectors are not supported #33

firstinflight opened this issue Apr 14, 2014 · 1 comment

Comments

@firstinflight
Copy link

I've been using the excellent Base16 Twilight Dark color scheme, and have found that while periods in class selectors are supported in CSS files, they aren't supported in Sass files.

I believe this is supported in CSS by the Attribute ID (either entity.other.attribute-name.id or punctuation.definition.entity—my guess is the latter).

CSS (notice the blue period between the "a" and the "cta-button" class):
class punctuation in css

Sass (period between "a" and the "custom" class is the same color as the class):
class punctuation in sass

@P233
Copy link
Owner

P233 commented Nov 26, 2017

This package considers the . is part of the class selector as the # is part of the id selector and the :: is part of the pseudo-element selector. So they shouldn't be highlighted in a different colour.

Highlighting Sass selectors also need to consider interpolations, e.g. .class-#{$variable}, and highlight the punctuations and selector name in the same colour can make things easier :D

@P233 P233 closed this as completed Nov 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants