Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

latest update completely broke highlight #65

Closed
MartinFugess opened this issue Nov 26, 2017 · 18 comments
Closed

latest update completely broke highlight #65

MartinFugess opened this issue Nov 26, 2017 · 18 comments

Comments

@MartinFugess
Copy link

@leereichardt
Copy link

leereichardt commented Nov 26, 2017

It has also broken the Goto Symbol window. It no longer only displays the function list, it displays every use of every keyword of every function.

I've had to remove this plugin for now

@tedc
Copy link

tedc commented Nov 27, 2017

And all the CSS autocompletions no longer work.
Please fix it.

@P233
Copy link
Owner

P233 commented Nov 27, 2017

Hi @MartinFugess, I have pushed an update a few hours ago. Could you double check if the property name is highlighted as in the old version? Thanks

@P233
Copy link
Owner

P233 commented Nov 27, 2017

@tedc Could you let me know which autocompletions you are using? The built-in completions of the old version has been removed. And I think and tested the Emmet plugin works great for providing CSS completions.

@MartinFugess
Copy link
Author

MartinFugess commented Nov 27, 2017

current state after last update [27.11.2017 / 14:55]:

3 years old version with correct highlighting:

@tedc
Copy link

tedc commented Nov 27, 2017

@P233 I'm using Emmet. If I switch syntax highlighting to SCSS, autocompletion stops working. With SASS highlighting checked, everything is fine.

The syntax selected:

screenshot 2017-11-27 15 08 55

If I try to write some css property:

screenshot 2017-11-27 15 09 10

@iamsisar
Copy link

there are also scope issues with non-spaced values after property name..

screen shot 2017-11-27 at 15 38 37

@P233
Copy link
Owner

P233 commented Nov 27, 2017

@MartinFugess In the new version, pseudo class and pseudo element have a new scope name entity.other.pseudo-class.css.sass which is inherited from the default Sublime Text CSS package. So it may not be highlighted in some colour schemes but be highlighted is some other colour schemes, I am not very sure. I am just trying to respect the scope naming of the Default CSS package.

Comma is not highlighted as in the old version.

@mugukamil
Copy link

I also have issues with last update...

if I commented some rule, it comments all lines down...

image

@P233
Copy link
Owner

P233 commented Nov 27, 2017

@tedc That's strange because I just tested and the emmet popup works in SCSS syntax but not in Sass syntax.Actually, if I type "dn" and press tab in Sass syntax, it still completes "display: none" only the popup window doesn't disappear.

I'll keep looking for a solution. Sorry for the inconvenience.

@P233
Copy link
Owner

P233 commented Nov 27, 2017

@mugukamil I just pushed a quick fix. Sorry for the inconvenience. Please wait for the package control update.

@MartinFugess
Copy link
Author

I use default monokai scheme with adaptive theme on latest sublime version [3.0, 3143].
Old version yours plugin highlight correct pseudoclass and pseudoelements, new version not.
For example, the each is also wrong highligted.

@dallington
Copy link

@MartinFugess I'm going through the same thing :s

@P233
Copy link
Owner

P233 commented Nov 28, 2017

@MartinFugess @dallington I just pushed another update to fix the variables within @each. Please wait for the package control update and take a look.

@iamsisar The non-spaced value issue is also fixed in the latest version.

@amrelkerm
Copy link

please can you explain this 's extension in the video tutorial I don't know how I can use this's the extension thank you

@P233
Copy link
Owner

P233 commented Dec 1, 2017

@Amr789 You don't have to learn anything to use this plugin. Install this plugin through the package control, then open any .sass or .scss files, the syntax should be get highlighted.

@P233 P233 closed this as completed Dec 1, 2017
@P233
Copy link
Owner

P233 commented Dec 10, 2017

@tedc Is your issues solved? Could you check the css_completions_scope field of your emmet settings file and make sure the source.scss scope is in the list?

I just noticed the source.sass scope is not included by default, so the emmet CSS completions don't pop up in .sass files.

I am thinking about maybe adding source.scss - comment - variable - keyword.control - entity.other to the css_completions_scopefiled could solve your issue.

@tedc
Copy link

tedc commented Dec 11, 2017

@P233 yes, css completions now work fine but, before this update, completions worked also with sass/scss variables and all the other strings used in the same file I was working with. Now they didn't suggest/complete any of these.

i.e. If, in my _some-style.scss I have a $color string, completions give me $color when I was typing $c (in general, a part of the string). The same for css property ("transform: tran" became "transform: translate3d", with other choices in the dropdown).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants