Split up process_next_message() to facilitate overriding. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicente-gonzalez-ruiz
pushed a commit
that referenced
this pull request
Jul 13, 2015
Split up process_next_message() to facilitate overriding.
|
Thanks (again). |
mertemba
added a commit
to mertemba/p2psp
that referenced
this pull request
Jul 13, 2015
vicente-gonzalez-ruiz
pushed a commit
that referenced
this pull request
Jul 13, 2015
Fixed typo made in pull request #48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to handle messages of custom format, peers inheriting from Peer_DBS have to copy the
process_next_message(self)method and adapt it to new messages.With this change, inheriting peers can override the
process_message(self, message, sender)method and implement their case differentiation. In case the inheriting class does not handle the received message, the base class method can be called.