-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PISC with pipelines(tna_simple_router, tiny_router_v2 without vlan module) #2
base: master
Are you sure you want to change the base?
Conversation
-Modify info, dump message format -Add all of the table flag in dump.go -Add PISC logo into version.go -Fix Makefile -Fix import path of main.go -Fix go-bfrt to pisc, bfcli to pisc-cli
6060c0b
to
fbc6261
Compare
-Fix dump error of out of range case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have more comment about function in utils.go. The format can reference in https://blog.golang.org/godoc
- Add README.md - Add description of util's function - Remove unused variable - Fix info that error doesn't occur when table Id is not found
36407a4
to
4a9dc27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to remove unused code.
cmd/utils.go
Outdated
//name, ok = p4Info.SearchActionParameterNameById(id) | ||
//if ok == true { | ||
// return name, found | ||
//} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this code is not used, remove please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
README.md
Outdated
``` | ||
2. all : delete all entries of the table | ||
``` | ||
//Do not confuse with set-flow's "-a" flag. It's totally diffrent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ 和 D 之間少一個空格
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it.
-Fix README blank in message -Remove unused code in utils.go
PISC-CLI -Add set-flow, del-flow, info, table, version function. * Fixed or removed issues - Fix table completion to remove the Parser table showing up. - Fix del-flow out of index problem. - Remove feature that deleting entry by entry number * New feature - Add deleting entry by match keys - Modify the write request(delete) to delete multiple entities at once. - Modify the dump function(print format) - Add go.mod - Add table name suggestion - Add dump counts function - Add the dump count flag -c to take out a number of entries * Document related - Modify README for the new version of the flow setup method - Modify flow cheatsheet
- Make pisc-cli compatible with tiny_router_v2 pipeline. - Modify dump command print format. Using tablewriter package. - Modify info command to use string concatenation instead io buffer. - Add read file feature to set-flow function *W.I.P - Show the progress using progress bar when large number of entries are come. - make the code more compact
- Fix the counting error of the readfile feature - Add progress bar to del-flow command - Add progress bar to set-flow command(readfile only) - Fix del-flow bugs - Tested set-flow/del-flow performance(del-flow has performance issue, Readtable function of PISC is too slow.) W.I.P - Fix suggestion function - Adding PRE related function(non p4 Object),
-Tab completion provides table,action name when use set/del-flow, dump and info command
-Adding PRE related features(MGID, NODE, LAG, PRUNE) -Adding Port feature. Port command only support add port config now. It can't modify or delete port config.
-Added the VLAN "create" and "add" features -Fixed the flag shorthand collision problem. Now, the Server flag uses the capital charactor -Modified PRE command's tab completion to suggest the table name with "pre." suffix -Modified dump function bug when pipeline table key field counts don't matched to the bfrt profile
-Add delete feature. But not fully implemet. It just deletes one vlan group now.
…esponse message -Now, the vlan add feature support range config -read the response message from server
-Now, the "show" of VLAN cmd is available. vlan show has two options, one is show vlan by vlanId, the other is show vlan by portId. the usage of the "show" command please refer to the document in P4Networking/doc repo.
-use JSON.marshal to decode gRPC response message. -add show all vlans features. "pisc-cli vlan show" command will show all of the vlans -add range delete feature.
-Delete the vlan modify feature.
-Modifed the set-flow error messages -Fixed that the set-flow tab completion suggests abnomaly lists. -Fixed that the del-flow can't delete the flow when using -m flag.
Supporting PISC with (tna_simple_router, tiny_router_v2)
-Fix Makefile
-Fix import path of main.go
-Fix go-bfrt to pisc, bfcli to pisc-cli
-Add set-flow, del-flow, dump, info, table, version features.
-Add pre, port, vlan features.
README.md