Refactor for v3 #65
Closed
Refactor for v3 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic idea is to move towards a more functional approach. As you can see the code is a lot tighter than before but still retains its functionality. There is one major issue still outstanding and that is the rerendering issue. I need to look into this but you can run the demo and see that it does apply the rotation as expected albeit with a rerender for each frame (which we don't want). Will keep working on this over the coming while but appreciate any feedback on the pros/cons of this implementation and also any ideas on how to resolve the rerendering issue that you may have. Until then I will see what I can do on my end and update as I go.
Adds the ability for users to pass an props to the wrapper instance and each of these attributes will be in turn put onto the wrapper such as id / class / etc.
Merging since its a minor change although a review in future would be nice..
* Updated dependencies * Updated package-lock for sanity check * Fixing NCU issue with updating devDependencies
Closed
This was
linked to
issues
Dec 6, 2020
This was referenced Dec 6, 2020
|
Released the main changes as part of #101. A few more changes will be added before the version 3 release but we are almost there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic idea is to move towards a more functional approach. As you can see the code is a lot tighter than before but still retains its functionality. There is one major issue still outstanding and that is the rerendering issue. I need to look into this but you can run the demo and see that it does apply the rotation as expected albeit with a rerender for each frame (which we don't want). Will keep working on this over the coming while but appreciate any feedback on the pros/cons of this implementation and also any ideas on how to resolve the rerendering issue that you may have. Until then I will see what I can do on my end and update as I go.