Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NPM Scripts #77

Merged
merged 6 commits into from
Mar 14, 2021
Merged

Improve NPM Scripts #77

merged 6 commits into from
Mar 14, 2021

Conversation

yevdyko
Copy link
Collaborator

@yevdyko yevdyko commented Mar 13, 2021

Hey @jamesrweb

When testing the latest changes on master, I found that not all npm scripts are up to date. So this MR updates them and adds some missing steps. Hope you will find it useful.

What was changed?

  • Commit changes to the package.json and package-lock.json files properly after install.
  • Fix the npm start script. After updating webpack-cli to v4 we should use webpack serve to run webpack-dev-server.
  • Add the npm clean script as a first step when compiling lib.
  • Add react-dom as a peer dependency.
  • Remove the unused npm build script. There is no prod webpack config and it looks like the script is not used.
  • Rename the npm compile script to npm build script.

After updating webpack-cli to v4 we should use 'webpack serve' to run 'webpack-dev-server'
There is no prod wepback config and it looks like the script is not used.
@jamesrweb jamesrweb merged commit e8fe6dd into P5-wrapper:master Mar 14, 2021
@yevdyko yevdyko deleted the chore/improve-npm-scripts branch March 14, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants