New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to the latest versions #85
Update dependencies to the latest versions #85
Conversation
@yevdyko Do we need the dependency in both dependencies and peer dependencies? Also, does the .x syntax work? Never seen this before and if it does, can you give a quick explainer for future reference? |
@jamesrweb I think you are right about As for the Maybe, we need to add the minimum version for React as a peer dependency based on the used features in the library. |
After some thinking, I remembered that it was actually added there by me as a peer dependency because of an issue I resolved where users installing the library has a I would prefer using the |
I removed the
The only reason to use |
Merged the current PR, for follow up topics we can open a new one @yevdyko, great work so far, appreciate the contributions! 👌🏻 |
* Update p5 version to the latest 1.x * Update dependencies to the latest versions * Remove p5 from peer dependencies * Update dependencies since opening PR
This MR updates dependencies to the latest versions and removes
p5
from the peer dependencies.What was changed?
p5
version to the latest 1.3.1.p5
from peer dependencies.