Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERA-9326] Inserting updated Spanish translations #1097

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JoshuaVulcan
Copy link
Collaborator

What does this PR do?

  • This PR updates the translations to match those provided by review from the support team

Relevant link(s)

Copy link
Contributor

@luixlive luixlive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that part of the definition of Done of these tickets should be to provide an environment with the translations to the translators so they can corroborate that the wording makes sense in the UI context. I think I see a couple of things here that make sense as a literal translation of the English texts, but that may not make much sense in the app. Anyway, I didn't want to got through each text, this will happen in other languages too, so instead I think we should include a step for validating in the UI.

Btw, since you didn't bump up the version, people that have the Spanish translations from the development env cached won't see these changes until the cache expires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants