Security audit dependency updates... #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
luixlive
approved these changes
Dec 2, 2022
| @@ -68,6 +68,9 @@ const Nav = ({ | |||
| mainToolbarTracker.track('Select to operate as a user profile'); | |||
| setUserProfile(profile, isMainUser ? false : true); | |||
| } | |||
| setTimeout(() => { | |||
| window.location.reload(true); | |||
| }, [1000]); | |||
There was a problem hiding this comment.
Maybe a constant for this with a nice self-explanatory name 😄 ?
Alcoto95
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which I attached to the laziest/easiest P2 I could find in the backlog 🙂
https://era-8120.pamdas.org
https://allenai.atlassian.net/browse/ERA-8120
The majority of the changes here are in the
yarn.lockfile, which you can expand in the files changed section. A combination ofyarn auditandyarn upgrade <package-name>got me there.