Fixes constant loading spinner in Embeddings Projector.

PiperOrigin-RevId: 551200920
PAIR-code · Jul 26, 2023 · 21d523d · 21d523d
1 parent 4db0dec
commit 21d523d
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lit_nlp/client/modules/embeddings_module.ts b/lit_nlp/client/modules/embeddings_module.ts
@@ -418,8 +418,6 @@ export class EmbeddingsModule extends LitModule {
   }
 
   private async computeProjectedEmbeddings() {
-    this.isLoading = true;
-
     // Clear projections if dataset is empty.
     if (!this.appState.currentInputData.length) {
       this.projectedPoints = [];
@@ -430,6 +428,8 @@ export class EmbeddingsModule extends LitModule {
     if (!embeddingsInfo) {
       return;
     }
+
+    this.isLoading = true;
     const {modelName, fieldName} = embeddingsInfo;
 
     const datasetName = this.appState.currentDataset;
@@ -449,7 +449,10 @@ export class EmbeddingsModule extends LitModule {
     const promise = embeddingRequestCache.call(this.appState.currentInputData);
     const results =
         await this.loadLatest(`proj-${JSON.stringify(projConfig)}`, promise);
-    if (results === null) return;
+    if (results === null) {
+      this.isLoading = false;
+      return;
+    }
 
     // Compute sprite map if image data.
     if (this.appState.datasetHasImages) {