Rename remaining instances of String to StringLitType.

PiperOrigin-RevId: 462523569
PAIR-code · Jul 22, 2022 · 65c5b8a · 65c5b8a
1 parent 72edd26
commit 65c5b8a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/lit_nlp/client/lib/lit_types.ts b/lit_nlp/client/lib/lit_types.ts
@@ -32,7 +32,7 @@ function registered(target: any) {
 const registryKeys = Object.keys(REGISTRY) as ReadonlyArray<string>;
 /**
  * The types of all LitTypes in the registry, e.g.
- * 'String' | 'TextSegment' ...
+ * 'StringLitType' | 'TextSegment' ...
  */
 export type LitName = typeof registryKeys[number];
 

diff --git a/lit_nlp/client/lib/types.ts b/lit_nlp/client/lib/types.ts
@@ -25,10 +25,10 @@ import {chunkWords, isLitSubtype} from './utils';
 export type D3Selection = d3.Selection<any, any, any, any>;
 
 export type LitClass = 'LitType';
-export type LitName = 'type'|'LitType'|'String'|'TextSegment'|'GeneratedText'|
-    'GeneratedTextCandidates'|'ReferenceTexts'|'URL'|'SearchQuery'|'Tokens'|
-    'TokenTopKPreds'|'Scalar'|'RegressionScore'|'CategoryLabel'|
-    'MulticlassPreds'|'SequenceTags'|'SpanLabels'|'EdgeLabels'|
+export type LitName = 'type'|'LitType'|'StringLitType'|'TextSegment'|
+    'GeneratedText'|'GeneratedTextCandidates'|'ReferenceTexts'|'URL'|
+    'SearchQuery'|'Tokens'|'TokenTopKPreds'|'Scalar'|'RegressionScore'|
+    'CategoryLabel'|'MulticlassPreds'|'SequenceTags'|'SpanLabels'|'EdgeLabels'|
     'MultiSegmentAnnotations'|'Embeddings'|'TokenGradients'|'TokenEmbeddings'|
     'AttentionHeads'|'SparseMultilabel'|'FieldMatcher'|'MultiFieldMatcher'|
     'Gradients'|'Boolean'|'TokenSalience'|'ImageBytes'|'SparseMultilabelPreds'|

diff --git a/lit_nlp/client/modules/datapoint_editor_module.ts b/lit_nlp/client/modules/datapoint_editor_module.ts
@@ -109,7 +109,7 @@ export class DatapointEditorModule extends LitModule {
       const fieldSpec = this.appState.currentDatasetSpec[key];
       let calculateStringLength : ((s: string) => number) | ((s: string[]) => number);
 
-      if (isLitSubtype(fieldSpec, ['String', 'TextSegment'])) {
+      if (isLitSubtype(fieldSpec, ['StringLitType', 'TextSegment'])) {
         calculateStringLength = (s: string) => s.length;
       }
       else if (isLitSubtype(fieldSpec, 'SparseMultilabel')) {

diff --git a/lit_nlp/client/modules/embeddings_module.ts b/lit_nlp/client/modules/embeddings_module.ts
@@ -416,8 +416,9 @@ export class EmbeddingsModule extends LitModule {
   }
 
   private getLabelByFields() {
-    return findSpecKeys(this.appState.currentDatasetSpec,
-                        ['TextSegment', 'Scalar', 'String', 'CategoryLabel']);
+    return findSpecKeys(
+        this.appState.currentDatasetSpec,
+        ['TextSegment', 'Scalar', 'StringLitType', 'CategoryLabel']);
   }
 
   private getImageFields() {