Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New stage] Add implicit reveal stage (to show results, solutions, and team score) #17

Open
cjqian opened this issue May 2, 2024 · 2 comments
Labels
feature New feature or request

Comments

@cjqian
Copy link
Member

cjqian commented May 2, 2024

In the vote reveal panel, display

  1. Who was elected as the team leader
  2. The final resulting task order
  3. The correct task order (with an explanation or info icon popup?)
  4. A scoring indicator (see appendix o

Image

f https://docs.google.com/document/d/11IJXf-tZVKZp592-MNM3hIj9Rft6cBYV7UcYFS9VJJc/)

@cjqian cjqian added the feature New feature or request label May 2, 2024
@cjqian cjqian added this to the ⭐️ Playtest Prototype milestone May 2, 2024
cjqian added a commit that referenced this issue May 23, 2024
@cjqian cjqian self-assigned this May 23, 2024
@vivtsai
Copy link
Collaborator

vivtsai commented Jun 15, 2024

Updated proposal (see components doc) for this implementation:

  1. Add result/scoring configuration settings to relevant existing stages (e.g., leader election stage)
  2. Add an implicit stage for displaying all reveals/results (automatically added to experiment if 1+ stages have results/scoring configured)

@vivtsai vivtsai changed the title [Result reveal] Show results, solutions, and team score [New stage] Add implicit reveal stage (to show results, solutions, and team score) Jun 15, 2024
@vivtsai
Copy link
Collaborator

vivtsai commented Jun 15, 2024

The Lit frontend has an MVP "reveal" stage, i.e., results preview for election (vote for leader) stage:

lit/src/experiment-components/modules/election/election_reveal.ts

Ideally, we want this election preview component, along with new components for Lost at Sea reveals, to be rendered inside a new implicit Reveal stage component.

Note that setting this up will involve:

(a) adding implicit-ness: cleaning up experiment_config and utils logic around adding the reveal stage (e.g., make sure exactly 1 reveal stage is present iff. at least one of the other stages has results configured)

(b) showing multiple reveals: updating (or replacing) the current RevealVoted stage in backend (which can only be tied to one VoteForLeader stage - instead, we'll want it to link to all stages with results). Actually, the fastest way to do this might be to ignore this backend field and instead select stages on the frontend (i.e., when rendering the new Reveal component, just check all the other stages to see which ones have results configured)?

@cjqian cjqian removed their assignment Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants