Improve slow startup with large reaction networks #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a container DispatchMethodLists with untyped fields instead of a NamedTuple for dispatch lists returned by create_dispatch_methodlists(), so the typed Tuple of methods is only dispatched on at the final call to dispatch_methodlist() (a generated function) This seems to improve the time for the first call to 'do_deriv', so the startup time for generated_dispatch = true is now similar to generated_dispatch = false. Presumably it was passing around large typed Tuples or NamedTuples that was causing problems, not the @generated dispatch_methodlist() NB: there is now a dynamic dispatch in do_deriv (one for each of list_initialize, list_do).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a container DispatchMethodLists with untyped fields instead of a NamedTuple for dispatch lists returned by create_dispatch_methodlists(), so the typed Tuple of methods is only dispatched on at the final call to dispatch_methodlist() (a generated function)
This seems to improve the time for the first call to 'do_deriv', so the startup time for generated_dispatch = true is now similar to generated_dispatch = false. Presumably it was passing around large typed Tuples or NamedTuples that was causing problems, not the
@generated dispatch_methodlist()NB: there is now a dynamic dispatch in do_deriv (one for each of list_initialize, list_do).