PP-410: Improvement to server logging ...

[agrawalravi90]

Issue-ID

• PP-410

Problem description

When pbs_server would fail because of a failed fork() inside go_to_background(),
there was no error/log message printed which would let the admin know of what
happened.

Solution description

Added a call to log_err() inside go_to_background() when fork fails.

Checklist:

• I have joined the pbspro community forum.
• My pull request contains a single, signed commit. See setting up gpg signature.
• My code follows the coding style of this project.
• My change requires project documentation. See required documentation checklist for details.
• I have added documentation in the project documentation area.
• I have added new PTL test(s) to my commit. (See using PTL for testing) (or)
• I have added manual test(s) to the Jira ticket and explained why PTL is not appropriate for this case.
• All new and existing automated tests have passed. (See running automated PTL tests).
• I have attached test logs to the Jira ticket as evidence of testing/verification.

****For further information please visit the Developer Guide Home.****

[mike0042]

Do we want to supply the errno?

[bhroam]

I think the errno provides the error message of the failure to allocate memory.

I like the change. I sign off.

[agrawalravi90]

@bhroam thanks for the sign-off.

@mike0042 Yes, we do need to provide an errno for log_err to print the correct message via strerror() as fork() can fail due to any of the following three reasons:

[EAGAIN] The system-imposed limit on the total number of pro-
cesses under execution would be exceeded. This limit
is configuration-dependent.

[EAGAIN] The system-imposed limit MAXUPRC (<sys/param.h>) on the
total number of processes under execution by a single
user would be exceeded.

[ENOMEM] There is insufficient swap space for the new process.

[mike0042]

Bhroam is correct. Sorry about that. I'll merge the pull request.

[agrawalravi90]

Thanks!