Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient privileges causes Test_explicit_psets to fail #917

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

latha-subramanian
Copy link
Contributor

Bug/feature Description

Insufficient privileges to set sched attributes causes test_only_explicit_psets in pbs_only_explicit_psets.py fail

Affected Platform(s)

  • All

Cause / Analysis / Design

The sched attributes, 'only_explicit_psets' and 'do_not_span_psets can be set only by managers and operators. The test user is not added to the managers list and hence test fails when attempting to set these attributes.

Solution Description

Call TestFunctional.setUp() so the test user is added to the managers' list.

Testing logs/output

afterfix_explicit_psets.txt
beforefix_explicit_psets.txt

Checklist:

For further information please visit the Developer Guide Home.

@vstumpf vstumpf self-assigned this Dec 11, 2018
Copy link
Contributor

@vstumpf vstumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

Copy link
Contributor

@nishiya nishiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@latha-subramanian
Copy link
Contributor Author

Thanks @vstumpf and @lisa-altair .I have rebased for merge.

@PBSPro/pbspro-maintainers, this PR is ready for merge.

@mike0042 mike0042 merged commit 21a1168 into openpbs:master Dec 12, 2018
@latha-subramanian
Copy link
Contributor Author

Thanks @mike0042

@latha-subramanian latha-subramanian deleted the explicitpsets branch December 12, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants