replace addAll with param ctor #1771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpr
requested changes
Oct 4, 2016
| choices.addAll(baseSet.getContainedObjects()); | ||
| RETAIN: for (Iterator<T> it = choices.iterator(); it.hasNext();) | ||
| Set<T> choices = new HashSet<>(baseSet.getContainedObjects()); | ||
| RETAIN: for (Iterator<T> it = choices.iterator(); it.hasNext();) |
There was a problem hiding this comment.
Can you have this indented as before, please?
| final List<BonusObj> aList = new ArrayList<>(); | ||
|
|
||
| aList.addAll(BonusUtilities.getBonusFromList(getBonusList(pc), aType, | ||
| final List<BonusObj> aList = new ArrayList<>(BonusUtilities.getBonusFromList(getBonusList(pc), aType, |
There was a problem hiding this comment.
line length issue, please rewrap
| @@ -1295,8 +1295,8 @@ public String getHTMLInfo(KitFacade kitFacade) | |||
| infoText.appendI18nElement("in_requirements", aString); //$NON-NLS-1$ | |||
| } | |||
|
|
|||
| List<BaseKit> sortedObjects = new ArrayList<>(); | |||
| sortedObjects.addAll(kit.getSafeListFor(ListKey.KIT_TASKS)); | |||
| List<BaseKit> sortedObjects = new ArrayList<>(kit.getSafeListFor(ListKey.KIT_TASKS)); | |||
| @@ -300,8 +300,8 @@ public static String getSAToken(PCTemplate template, PlayerCharacter pc) | |||
| List<SpecialAbility> saList = new ArrayList<>(); | |||
| saList.addAll(display.getResolvedUserSpecialAbilities(template)); | |||
| saList.addAll(display.getResolvedSpecialAbilities(template)); | |||
| List<PCTemplate> subList = new ArrayList<>(); | |||
| subList.addAll(template.getConditionalTemplates(display.getTotalLevels(), display.totalHitDice())); | |||
| List<PCTemplate> subList = new ArrayList<>(template.getConditionalTemplates(display.getTotalLevels(), display.totalHitDice())); | |||
grimreaper
force-pushed
the
eax/collect/collect
branch
from
b995378
to
6fb9564
Compare
grimreaper
force-pushed
the
eax/collect/collect
branch
from
6fb9564
to
3e67c13
Compare
|
wrapping fixed; rebased |
Shredder121
reviewed
Nov 9, 2016
| @@ -375,8 +375,7 @@ public String getInfo(PlayerCharacter aPC) | |||
| info.append(" <b>Requirements</b>: ").append(aString); | |||
| } | |||
|
|
|||
| List<BaseKit> sortedObjects = new ArrayList<>(); | |||
| sortedObjects.addAll(getSafeListFor(ListKey.KIT_TASKS)); | |||
| List<BaseKit> sortedObjects = new ArrayList<>(getSafeListFor(ListKey.KIT_TASKS)); | |||
| Collections.sort(sortedObjects, new ObjectTypeComparator()); | |||
There was a problem hiding this comment.
Keep in mind, this clashes a bit with your other PR with the list.sort() calls.
There was a problem hiding this comment.
my recent PRs were automated. I have some non-automate coming up too though.
thpr
requested changes
Nov 12, 2016
| @@ -6146,9 +6146,8 @@ private void resolveLanguages() | |||
| int currentBonusLang = thePC.getDetailedAssociationCount(langbonus); | |||
| boolean foundLang = currentBonusLang > 0; | |||
|
|
|||
| Set<Language> foundLanguages = new HashSet<>(); | |||
| Set<Language> foundLanguages = new HashSet<>(thePC.getLanguageSet()); | |||
| //Captures Auto (AUTO:LANG) and Persistent choices (ADD ex ability and CHOOSE) | |||
There was a problem hiding this comment.
This comment is now out of place and needs to be moved above the construction
grimreaper
force-pushed
the
eax/collect/collect
branch
from
3e67c13
to
f201ac9
Compare
|
tweaks completed |
grimreaper
force-pushed
the
eax/collect/collect
branch
3 times, most recently
from
ca9eeaf
to
791f94d
Compare
grimreaper
force-pushed
the
eax/collect/collect
branch
from
791f94d
to
cc64323
Compare
|
Can you remove data/pathfinder/homebrew/eax_custom please? |
grimreaper
force-pushed
the
eax/collect/collect
branch
from
cc64323
to
5c4be2a
Compare
grimreaper
force-pushed
the
eax/collect/collect
branch
from
5c4be2a
to
3f62ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.