Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proxy Support, Add IOptions Pattern, Add Extensions Method #15

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

xpsony
Copy link
Contributor

@xpsony xpsony commented Apr 14, 2024

Currently Changes

Http / Https proxy support has been added , To disguise the Ip address or if a proxy service is required
IOptions pattern has been implemented. Better options handling
Extensions methods have been implemented to make Program.cs smaller
Added a global logger for static and extension methods
appsettings.json now contains "default" data for the applications and proxy settings. The Docker variables are also specified above it. This also fixes the bug that you have to set all variables, although you only want to use Sonarr, for example
Breaking Change :

Because Microsoft parses the Env variables differently for IOptions. The following changes must be made for existing users.

Wherever "_" is used, "__" must now be used

Example :

SONARR_ENABLED becomes SONARR__ENABLED

Further examples can be found in appsettings.json

I don't know if there is a way to customise the format. But this is the standard that Microsoft recommends

Note : Only tested with Sonarr , but the Others should work too

Currently Changes

Http / Https proxy support has been added , To disguise the Ip address or if a proxy service is required
IOptions pattern has been implemented. Better options handling
Extensions methods have been implemented to make Program.cs smaller
Added a global logger for static and extension methods
appsettings.json now contains "default" data for the applications and proxy settings. The Docker variables are also specified above it. This also fixes the bug that you have to set all variables, although you only want to use Sonarr, for example
@xpsony
Copy link
Contributor Author

xpsony commented Apr 14, 2024

This is the same like Pull Request 9. I destroyed the Git project and had to make it beautiful again

@PCJones PCJones merged commit 49565be into PCJones:develop Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants