Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to ierr rather than overwrite #381

Merged
merged 1 commit into from Aug 3, 2018
Merged

Add to ierr rather than overwrite #381

merged 1 commit into from Aug 3, 2018

Conversation

ehogan
Copy link
Contributor

@ehogan ehogan commented Jul 31, 2018

Fixes #374.

@ehogan ehogan mentioned this pull request Jul 31, 2018
Closed
@ehogan
Copy link
Contributor Author

ehogan commented Jul 31, 2018

The problem is that ierr is overwritten by the output from cmor_CreateFromTemplate rather than added to (ierr is added to when checking the CVs, which occurs in the code just above the call to cmor_CreateFromTemplate). did_history == 0 is only true for the first variable, so when attempting to produce a second variable, the loop was not entered and ierr was not overwritten.

doutriaux1
doutriaux1 approved these changes Jul 31, 2018
View reviewed changes
Copy link
Collaborator

@doutriaux1 doutriaux1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@doutriaux1
Copy link
Collaborator

@ehogan not sure why the ci are not finished yet. Maybe I'll bring your fork into this repo and see if it triggers the ci. Waiting a bit longer first.

@doutriaux1 doutriaux1 merged commit 8406273 into PCMDI:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doutriaux1 doutriaux1 doutriaux1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehogan @doutriaux1