Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Climo output name #579

Merged
merged 11 commits into from
Oct 25, 2018
Merged

Climo output name #579

merged 11 commits into from
Oct 25, 2018

Conversation

doutriaux1
Copy link
Contributor

@gleckler1 please try and your param file
you need to add

output_filename_template to your parm file

e.g

output_filename_template = "%(variable)_%(model)_%(experiment_id).nc"

@gleckler1
Copy link
Contributor

@doutriaux1 I think genutil needs to be imported for this to work. I'm trying to do that but not succeeding yet...

@doutriaux1
Copy link
Contributor Author

@gleckler1 can you try it today?

@coveralls
Copy link

coveralls commented Oct 11, 2018

Pull Request Test Coverage Report for Build 659

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 45.521%

Files with Coverage Reduction New Missed Lines %
test_linux_pmp_py3/miniconda/envs/py3/bin/computeStdDailyMeansWrapped.py 48 32.97%
Totals Coverage Status
Change from base Build 635: -0.6%
Covered Lines: 1834
Relevant Lines: 3691

💛 - Coveralls

@gleckler1
Copy link
Contributor

@doutriaux1 Getting climo working with obs is the most important thing to accomplish right now. I will give it a go today, and hope you can help when probs arise.

@gleckler1
Copy link
Contributor

@doutriaux1 working on this now... Q about time... I think the calendar is supposed to reflect its climo, isn't it? Also, not sure the time bounds below are correct...

double time(time) ;
	time:bounds = "bounds_time" ;
	time:axis = "T" ;
	time:calendar = "gregorian" ;

time = 3243.5, 3273, 3302.5, 3333, 3363.5, 3394, 3424.5, 3455.5, 3486,
3516.5, 3547, 3577.5 ;

bounds_time =
1401, 5450,
1432, 5478,
1461, 5509,
1492, 5539,
1522, 5570,
1553, 5600,
1583, 5631,
1614, 5662,
1645, 5692,
1675, 5723,
1706, 5753,
1736, 5784 ;

@durack1
Copy link
Collaborator

durack1 commented Oct 15, 2018

@gleckler1 use ncdump -ct $file.nc and this will map the time axis entries, using the calendar to something more intelligible..

@gleckler1
Copy link
Contributor

@durack1 rag nag, work on your paper

@gleckler1 gleckler1 closed this Oct 15, 2018
@gleckler1 gleckler1 reopened this Oct 15, 2018
@doutriaux1
Copy link
Contributor Author

@gleckler1 let's talk about it tomorrow when i'm in.

@gleckler1
Copy link
Contributor

@doutriaux1 Making great progress with this code, the only thing I need currently is to be able to include the CMOR generated into the results_dir and output_filename_template that are being fed via the command line (i.e., not in param file). I suppose I could create the version (date) from within my driver but for consistency probably better to have CMOR produce the version. Otherwise... its working great!! We can discuss the climo time model later

@gleckler1
Copy link
Contributor

@doutriaux1 OK, this is now working well with obs so I support a merge. We can deal with the time axis later.

@doutriaux1
Copy link
Contributor Author

@gleckler1 did your push broke the repo?

@doutriaux1
Copy link
Contributor Author

@gleckler1 please fix flake8

@gleckler1
Copy link
Contributor

@doutriaux1 I have no idea what that means

@doutriaux1
Copy link
Contributor Author

I'll do it... But you guys GOT to learn how to clean up your code.

@gleckler1
Copy link
Contributor

@doutriaux1 Now you've got me really confused. I have not made any changes to this branch - you did it all.

@gleckler1
Copy link
Contributor

@doutriaux1 I see you have two versions of it:
src/python/pcmdi/scripts/clim/pcmdi_compute_climatologies.py
src/python/pcmdi/scripts/pcmdi_compute_climatologies.py
Looks like the majority of changes are in the one in /clim

@gleckler1
Copy link
Contributor

@doutriaux1 Ain’t this good to go?

@doutriaux1
Copy link
Contributor Author

no "somebody" needs to fix flake8 that "somebody else" broke 😉

@doutriaux1 doutriaux1 merged commit 1635473 into master Oct 25, 2018
@doutriaux1 doutriaux1 deleted the climo_output_name branch October 25, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants