Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda forge pinning #634

Merged
merged 7 commits into from
Jan 28, 2020
Merged

Conda forge pinning #634

merged 7 commits into from
Jan 28, 2020

Conversation

muryanto1
Copy link
Contributor

@muryanto1 muryanto1 commented Jan 23, 2020

updated .circleci/config.yml to use the new conda-recipes' build_tools/conda_build.py which built the package using 'conda build' and install the built package using --use-local in the test environment.
conda-recipes' build_tools/conda_build.py also builds using conda-forge-pinning.
This way, we are really testing the package which is going to be put in pcmdi/label/nightly (if tests pass).
With this PR, you will see coverage went down to from 77% to 59%.
In the past, we ran tests with --coverage-from-egg option which does not work anymore since we built using 'conda build', and the coverage were including coverage from the test code itself which ofcourse are 100% (since we ran all testcases), as a result, you see a higher coverage number (77%) which I think can be misleading, since we really want to see the coverage on the code itself.

I also updated the name of job in the circleci workflow, instead of linux_pmp_py3, I renamed it to linux_pmp_py37.
You can ignore the linux_pmp_py3 and macos_pmp_py3, those jobs do not exist anymore.

@durack1
Copy link
Collaborator

durack1 commented Jan 24, 2020

@lee1043 @gleckler1 I will leave the review to you guys

@durack1 durack1 removed their request for review January 24, 2020 01:14
@lee1043
Copy link
Contributor

lee1043 commented Jan 26, 2020

@muryanto1 one question; any change if this change make the CircleCI indication as "Failed" because of dropped coverage percentage?

@muryanto1
Copy link
Contributor Author

@lee1043 the circleci ci "linux_pmp_py3" and "macos_pmp_py3" failures has nothing to do with coverage. They showed up as failed because those 2 jobs do not exist anymore. Once this PR merges, CircleCI should not show those 2 jobs.

@lee1043
Copy link
Contributor

lee1043 commented Jan 27, 2020

@muryanto1 good to know, thanks for clarifying.

@muryanto1 muryanto1 removed the request for review from doutriaux1 January 27, 2020 18:07
@muryanto1
Copy link
Contributor Author

@lee1043 @gleckler1 Jiwoo gave me a go to merge this PR.

@muryanto1 muryanto1 removed the request for review from gleckler1 January 27, 2020 23:59
@coveralls
Copy link

coveralls commented Jan 28, 2020

Coverage Status

Coverage decreased (-17.6%) to 59.151% when pulling 76cd9a6 on conda_forge_pinning into 21cd7c0 on master.

@muryanto1 muryanto1 merged commit 829dc09 into master Jan 28, 2020
@muryanto1 muryanto1 deleted the conda_forge_pinning branch July 9, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants