Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud feedback metric #851

Merged
merged 54 commits into from
Feb 17, 2023
Merged

Cloud feedback metric #851

merged 54 commits into from
Feb 17, 2023

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented May 19, 2022

PR opened for tracking changes for cloud metric implementation.

lee1043 and others added 20 commits May 19, 2022 09:59
@lee1043
Merge pull request #850 from PCMDI/main
7c2c4d8 
Update an old working branch
@lee1043
Merge branch 'main' into 741_ljw_cloud
e571db5
@lee1043
Merge branch 'main' into 741_ljw_cloud
316f65d
@lee1043
initial commit
dc41f36
@lee1043
in progress...
33e1aac
@lee1043
in progress... data also added -- perhaps temporarily
5b00761
@lee1043
in progress... to make it runnable in the PMP framework
5e32d07
@lee1043
in progress... adjust hardcoded directory path level. temporary. Need…
1debb62 
… to make them flexible
@lee1043
pre-commit test, style change
aeb832b
@lee1043
add more data
8724ced
@lee1043
Merge branch 'main' into 741_ljw_cloud
c0401a4
@lee1043
working on user interface and output
fa3107b
@lee1043
allow user specify input nc files in input_nc_files.json
3c841cb
@lee1043
clean up and add debug option
67a9f6c
@lee1043
style formatting
bb28812
@lee1043
update README.md -- further update still needed
c5292cb
@lee1043
clean up
0431fad
@lee1043
modulize argparse part
e65ea7b
@lee1043
pre-commit compliance in code style
a814430
@lee1043
Merge branch 'main' into 741_ljw_cloud
c90aec9
@lee1043 lee1043 linked an issue Aug 22, 2022 that may be closed by this pull request
Implement cloud metrics into PMP #741
Closed
@lee1043 lee1043 mentioned this pull request Sep 22, 2022
Closed
@lee1043 lee1043 self-assigned this Oct 13, 2022
@lee1043 lee1043 added this to the 3.0 milestone Oct 19, 2022
@lee1043 lee1043 linked an issue Feb 9, 2023 that may be closed by this pull request
Add more metrics/statistics for clould feedback #888
Closed
@lee1043 lee1043 marked this pull request as ready for review February 13, 2023 22:23
acordonez
acordonez approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked as expected in my testing.

@lee1043 lee1043 merged commit 80c092e into main Feb 17, 2023
@lee1043 lee1043 deleted the 741_ljw_cloud branch February 17, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acordonez acordonez acordonez approved these changes

Assignees

@lee1043 lee1043

Labels
enhancement New feature
Projects
None yet
Milestone
3.0
2 participants
@lee1043 @acordonez