Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New workflow for xcdat mean climate metrics #892

Merged
merged 139 commits into from
Feb 23, 2023

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Dec 9, 2022

In this PR:

  • CDAT in mean climate was replaced by xCDAT.
  • The mean climate driver was re-written from scratch with using some of existing functions, with substantial re-organization of the directory for mean climate metrics.
  • Many of class-based objects that over-complicates code maintenance were deprecated (moved to 'deprecated' directory, and will be removed later).

This PR is intended to replace the previous PR, #884.

@lee1043
Copy link
Contributor Author

lee1043 commented Feb 7, 2023

@acordonez I think this PR is ready for review. When you have a chance, could you take a look and also try run demo notebooks to ensure this change is not breaking the demo?

@acordonez
Copy link
Collaborator

@lee1043 will do

@lee1043
Copy link
Contributor Author

lee1043 commented Feb 7, 2023

@gleckler1 once this PR is merged, the capability of getting annual cycle using xcdat is going to be applicable to the obs4mips workflow in more efficient way.

@lee1043 lee1043 linked an issue Feb 22, 2023 that may be closed by this pull request
Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR in Demos 1a and 1b. Both notebooks run completely and produce the expected metric and netcdf files.

@lee1043 lee1043 merged commit e67791b into main Feb 23, 2023
@lee1043 lee1043 deleted the 859_pjg_xcdatclims_ljw_replace branch February 23, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment