-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mean climate 3d field vertical coordinate QC #978
Conversation
….com:PCMDI/pcmdi_metrics into mean_clim_3d_field_vertical_coord_unit_check
@acordonez when you get a chance, could you help checking if this PR makes any affect to the mean climate demo? No affect is expected but wanted to double check. |
@lee1043 Yes I'll test this out today |
@lee1043 The mean climate notebook 1b still runs with no errors. I did a before/after comparison for the Example 5 which uses zg_500 and am seeing some small (hundreths to thousandths place) differences in some of the metrics, for example rmsc_xy. It sounds like that is expected from this change? |
@acordonez @lee1043 Acceptable discrepancies for zg I think. You might compare with ta which in degrees C will be more intuitive. |
@acordonez thank you for checking this. @gleckler1 good point! I don't think we have obs for ta-850 in demo dataset, but I have compared to previously calculated from the PMP output database, and the difference is pretty subtle and I am confident on the consistency. |
Mean climate 3d field vertical coordinate QC