Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremes documentation for web #990

Merged
merged 12 commits into from
Jan 3, 2024
Merged

Extremes documentation for web #990

merged 12 commits into from
Jan 3, 2024

Conversation

acordonez
Copy link
Collaborator

@acordonez acordonez commented Oct 19, 2023

Create a new page for the extremes metrics on the Github.io documentation site. Copies most of the content from the Extremes README.

TODO: Add link to demo and portrait plot demo after merging extremes

@acordonez acordonez mentioned this pull request Oct 19, 2023
@lee1043
Copy link
Contributor

lee1043 commented Oct 19, 2023

@acordonez it looks great. How about adding a link to the demo notebook?

@lee1043 lee1043 added this to the v3.2 milestone Oct 19, 2023
@acordonez acordonez marked this pull request as draft October 20, 2023 23:21
@acordonez
Copy link
Collaborator Author

@lee1043 I've added a placeholder for the demo, since we haven't merged the final version yet (in case the notebook name changes or something like that).

@lee1043 lee1043 added the doc label Oct 21, 2023
@lee1043 lee1043 changed the base branch from main to 534_ao_extremes November 6, 2023 21:54
@lee1043
Copy link
Contributor

lee1043 commented Nov 6, 2023

PR re-directed to other PR (#962) so can be reviewed together.

Add link to demo notebook
@lee1043
Copy link
Contributor

lee1043 commented Nov 7, 2023

@acordonez is it okay to merge this to 535_ao_extremes branch?

@acordonez
Copy link
Collaborator Author

acordonez commented Nov 7, 2023

@lee1043 We can but I would need to make sure to update the links in the doc before that PR gets merged.

@lee1043 lee1043 changed the base branch from 534_ao_extremes to main November 9, 2023 00:07
@lee1043
Copy link
Contributor

lee1043 commented Nov 9, 2023

Base changed back to main

@lee1043
Copy link
Contributor

lee1043 commented Jan 1, 2024

@acordonez When you get a chance could you check extremes_driver.py -p basic_param.py --vars rlut pr part of the document? I think it is odd to have rlut there. Maybe tas, instead?

@acordonez
Copy link
Collaborator Author

acordonez commented Jan 3, 2024

@acordonez When you get a chance could you check extremes_driver.py -p basic_param.py --vars rlut pr part of the document? I think it is odd to have rlut there. Maybe tas, instead?

@lee1043 I've replaced the rlut with tasmax and tasmin

docs/metrics_ext.rst Outdated Show resolved Hide resolved
@lee1043 lee1043 marked this pull request as ready for review January 3, 2024 18:13
@lee1043
Copy link
Contributor

lee1043 commented Jan 3, 2024

@acordonez thank you, merging it now.

@lee1043 lee1043 merged commit 64fcdf9 into main Jan 3, 2024
5 checks passed
@lee1043 lee1043 deleted the 534_ao_docs branch January 3, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants