Skip to content

Commit

Permalink
gsdx-ogl: move the mandatory extension into mandatory section
Browse files Browse the repository at this point in the history
  • Loading branch information
@gregory38
gregory38 committed Apr 7, 2016
1 parent 121e92a commit b9e8384
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions plugins/GSdx/GLLoader.cpp
View file
Expand Up @@ -166,20 +166,20 @@ namespace GLLoader {
bool found_GL_ARB_clear_texture = false; // Miss AMD Mesa (otherwise seems SW)
// DX10 GPU limited driver (SW)
bool found_GL_ARB_copy_image = false;
bool found_GL_ARB_texture_barrier = false;
bool found_GL_ARB_clip_control = false;
bool found_GL_ARB_direct_state_access = false;
bool found_GL_ARB_separate_shader_objects = false;
bool found_GL_ARB_buffer_storage = false;
// DX11 GPU
bool found_GL_ARB_draw_buffers_blend = false; // Not supported on AMD R600 (80 nm class chip, HD2900). Nvidia requires FERMI. Intel SB
bool found_GL_ARB_gpu_shader5 = false; // Require IvyBridge
bool found_GL_ARB_shader_image_load_store = false; // Intel IB. Nvidia/AMD miss Mesa implementation.
bool found_GL_ARB_viewport_array = false; // Intel IB. AMD/NVIDIA DX10

// Mandatory
bool found_GL_ARB_texture_storage = false;
bool found_GL_ARB_buffer_storage = false;
bool found_GL_ARB_clip_control = false;
bool found_GL_ARB_direct_state_access = false;
bool found_GL_ARB_separate_shader_objects = false;
bool found_GL_ARB_shading_language_420pack = false;
bool found_GL_ARB_texture_barrier = false;
bool found_GL_ARB_texture_storage = false;

static bool status_and_override(bool& found, const std::string& name, bool mandatory = false)
{
Expand Down

8 comments on commit b9e8384

@tabnk
Copy link

@tabnk tabnk commented on b9e8384 Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD GPU show garbage now in OpenGL mode. A lot of black texture.

t1

@ssakash
Copy link
Member

@ssakash ssakash commented on b9e8384 Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously this commit isn't responsible for the issue, why are you mentioning here ?

You should mention over these places instead:
cef76de
a62019a
52e3c35
f751f70
dfb4b5a

(or) ask AMD as gregory suggested below.

@gregory38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all AMD users, if you're driver is still broken you can read/complain on this thread https://community.amd.com/thread/194895

@Nucleoprotein
Copy link

@Nucleoprotein Nucleoprotein commented on b9e8384 Apr 24, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think AMD user can only now play on Linux using mesa driver which should work ... AMD seems to not hurry with resolving problem with GL_ARB_separate_shader_objects 😞

PS: No, DX11 is not a alternative, is bugged and works much slower even for AMD users. You should remove DX11 or improve it, because is currently dead for me.

@gregory38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, on linux, you have the free driver (I'm afraid of the speed). Fixes was released months ago. On windows, you have DX11. Hopefully QA will soon be finish. So next driver release ought to contain the fix.

But let's be honest and bold, the alternative is to sell the AMD card to buy an Nvidia card. (it kills me because AMD does a very good jobs on the free world).

@Nucleoprotein
Copy link

@Nucleoprotein Nucleoprotein commented on b9e8384 Apr 24, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never, I hate nvidia for their proprietary technologies they never share, most AMD technology is open sourced now in GPUOpen initiative. Also AMD hardware is not so bad too, their Windows drivers have more bottlenecks that their hardware. AMD seems to pushing DX12 because they can make really simple driver and shift the whole work to game developers.
Linux mesa RadeonSI driver is quite fast, almost as fast like Catalyst or their new AMDGPU PRO (http://www.phoronix.com/scan.php?page=article&item=amd-win10-amdgpupro&num=1). Only is missing same OpenGL features, but OpenGL 4.3 is already done in git (https://mesamatrix.net/)

Summarizing about nvidia: https://www.youtube.com/watch?v=_36yNWw_07g 😄

@gregory38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I'm not sure you can extrapolate phoronix test which are gpu limited on PCSX2 which is cpu limited.

I'm not in love with Nvidia. But at least I can run PCSX2 at full speed since I bought my gtx760 (and without tons of driver bugs). So yeah AMD doesn't have any work force so they release everything in open source. (I'm mitigated if it is good or not). I won't call the free driver a success because there is few independent contributor.

@lightningterror
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is also present in intel igpus. Tested on HD 4400. Driver 10.18.14 (latest)

Please sign in to comment.