New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Regression) Tales of Legendia - Missing text / strange shadows #1574
Comments
It would help to have the sha1 version. Is the bug in SW or HW renderer ? Could you test latest git, I fixed something this morning. |
This comment has been minimized.
This comment has been minimized.
Each git commit is associated with a hash number (computed with sha1 algo). It is easier to lookup a commit this way. Dates aren't necessary in chronological order. Oh wait, actually maybe I have the sha1 I try to will give it a look as soon as possible. |
This game has Z depth issues with the hardware renderers. If this is a regression, the CRC hackfix for this game needs to be considered as well. |
This comment has been minimized.
This comment has been minimized.
the gs dump are fine on my side. Did you change some option recently ? What is your configuration ? I have CRC on minimum (below and you hit the half-screen issue above). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
not possible, this one add a gui option for windows. |
By the way to replay gsdump |
This comment has been minimized.
This comment has been minimized.
It's this commit: 310f13a |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@orbea could you force disable geometry shader and tell us if it is working. And try to disable accurate blending too. Based on @FlatOutPS2 feedback it is potentially an interaction between the 2. And it would explain why I can't reproduce it in the renderer. I will give it a look tomorrow. |
Yes, it is. The shadow issue only appears with Blending unit accuracy set to Medium or higher. |
Yes I can reproduce it now. Thanks you @FlatOutPS2 |
This comment has been minimized.
This comment has been minimized.
Good. It is probably minor but I need to have my full brain power to fix it properly ;) |
This comment has been minimized.
This comment has been minimized.
I'm trying to reduce the number of CRC hack #1575 |
This comment has been minimized.
This comment has been minimized.
Yes. The half screen bug is another story. Dunno what the game do. |
Wait, actually maybe I have fixed it see #1579 |
This comment has been minimized.
This comment has been minimized.
Ok I let's you play the game. If there is no issue, I will remove some crc hack. Need to have some feedback from dx user. |
@ramapcsx2 could you test a bit the new latest pull request without CRC on DX. Do you still have the half-screen bug ? |
…shader Recent optimization allow to use triangle to render sprite even when gs is supported close PCSX2#1574
OS:
Slackware64-current
pcsx2-2016.09.18_0f387a8_master-x86_64-1_git
Edit: Still occurs in
pcsx2-2016.09.19_b91bd3e_master-x86_64-1_git
.Last known working version:
pcsx2-2016.09.10_4796803_master-x86_64-1_git
Text in menus and in actions (i.e. Talk) is now missing and some areas produce strange shadows.
Apitrace:
http://ks392457.kimsufi.com/orbea/stuff/trace/PCSX2-TOL.trace.xz
GS Dumps:
http://ks392457.kimsufi.com/orbea/stuff/games/pcsx2/snaps/gsdx_TOL_20160919002635.gs.xz
http://ks392457.kimsufi.com/orbea/stuff/games/pcsx2/snaps/gsdx_TOL_20160919002720.gs.xz
http://ks392457.kimsufi.com/orbea/stuff/games/pcsx2/snaps/gsdx_TOL_20160919002830.gs.xz
How it should look:
The text was updated successfully, but these errors were encountered: