Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Regression) Tales of Legendia - Missing text / strange shadows #1574

Closed
orbea opened this issue Sep 19, 2016 · 28 comments
Closed

(Regression) Tales of Legendia - Missing text / strange shadows #1574

orbea opened this issue Sep 19, 2016 · 28 comments

Comments

@orbea
Copy link
Contributor

orbea commented Sep 19, 2016

OS: Slackware64-current
pcsx2-2016.09.18_0f387a8_master-x86_64-1_git
Edit: Still occurs in pcsx2-2016.09.19_b91bd3e_master-x86_64-1_git.

Last known working version: pcsx2-2016.09.10_4796803_master-x86_64-1_git

Text in menus and in actions (i.e. Talk) is now missing and some areas produce strange shadows.

Apitrace:
http://ks392457.kimsufi.com/orbea/stuff/trace/PCSX2-TOL.trace.xz

GS Dumps:
http://ks392457.kimsufi.com/orbea/stuff/games/pcsx2/snaps/gsdx_TOL_20160919002635.gs.xz
http://ks392457.kimsufi.com/orbea/stuff/games/pcsx2/snaps/gsdx_TOL_20160919002720.gs.xz
http://ks392457.kimsufi.com/orbea/stuff/games/pcsx2/snaps/gsdx_TOL_20160919002830.gs.xz

1
2
3

How it should look:
4
5

@gregory38
Copy link
Contributor

It would help to have the sha1 version. Is the bug in SW or HW renderer ? Could you test latest git, I fixed something this morning.

@orbea

This comment has been minimized.

@gregory38
Copy link
Contributor

Each git commit is associated with a hash number (computed with sha1 algo). It is easier to lookup a commit this way.

Dates aren't necessary in chronological order. Oh wait, actually maybe I have the sha1 0f387a8 and 4796803.

I try to will give it a look as soon as possible.

@ramapcsx2
Copy link
Member

This game has Z depth issues with the hardware renderers. If this is a regression, the CRC hackfix for this game needs to be considered as well.

@orbea

This comment has been minimized.

@gregory38
Copy link
Contributor

the gs dump are fine on my side. Did you change some option recently ? What is your configuration ? I have CRC on minimum (below and you hit the half-screen issue above).

@orbea

This comment has been minimized.

@orbea

This comment has been minimized.

@gregory38
Copy link
Contributor

not possible, this one add a gui option for windows.

@gregory38
Copy link
Contributor

By the way to replay gsdump
1/ build with -DBUILD_REPLAY_LOADERS=TRUE
2/ pcsx2_GSReplayLoader gsdx.so gsdump.gs bin/inis/ (update the path accordingly)

@orbea

This comment has been minimized.

@FlatOutPS2
Copy link
Contributor

It's this commit: 310f13a

@orbea

This comment has been minimized.

@orbea

This comment has been minimized.

@orbea

This comment has been minimized.

@gregory38
Copy link
Contributor

@orbea could you force disable geometry shader and tell us if it is working. And try to disable accurate blending too. Based on @FlatOutPS2 feedback it is potentially an interaction between the 2. And it would explain why I can't reproduce it in the renderer. I will give it a look tomorrow.

@FlatOutPS2
Copy link
Contributor

Yes, it is. The shadow issue only appears with Blending unit accuracy set to Medium or higher.

@gregory38
Copy link
Contributor

Yes I can reproduce it now. Thanks you @FlatOutPS2
Will fix it tomorrow.

@orbea

This comment has been minimized.

@gregory38
Copy link
Contributor

Good. It is probably minor but I need to have my full brain power to fix it properly ;)

@orbea

This comment has been minimized.

@gregory38
Copy link
Contributor

I'm trying to reduce the number of CRC hack #1575
Could you test the game with CRC set on minimal and tell me if it is good or if it still requires a higher hack level ?

@orbea

This comment has been minimized.

@gregory38
Copy link
Contributor

Yes. The half screen bug is another story. Dunno what the game do.

@gregory38
Copy link
Contributor

Wait, actually maybe I have fixed it see #1579

@orbea

This comment has been minimized.

@gregory38
Copy link
Contributor

Ok I let's you play the game. If there is no issue, I will remove some crc hack. Need to have some feedback from dx user.

@gregory38
Copy link
Contributor

@ramapcsx2 could you test a bit the new latest pull request without CRC on DX. Do you still have the half-screen bug ?

ramapcsx2 pushed a commit to ramapcsx2/pcsx2 that referenced this issue Oct 9, 2016
…shader

Recent optimization allow to use triangle to render sprite even when gs is supported

close PCSX2#1574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants