[Path 3 Masking Regression] - Eragon

[MrCK1]

PCSX2 version:
v1.5.0-dev-2266

PCSX2 options:
Defaults. Speedhacks do not affect the issue.

Plugins used:
Defaults, GSdx OGL

Description of the issue:
After booting, Eragon will hang on a black screen.

How to reproduce the issue:
Boot the game, observe

Last known version to work:
r5244, broken in r5245

PC specifications:
i5-6600K, GTX 1070, Windows 10 Home 64-bit

Blockdump (rename to .dump) - Eragon (2018-00-25 21-13-34).zip

Other relevant commits:
r5246
r5247
r5260
Google Code comments - SSX3 was broken in r5245 as well, but was fixed in r5265 - this does not apply to Eragon. - https://wiki.pcsx2.net/PCSX2_Documentation/Google_Code_svn_repository_comments_archive_5000_to_5499

Revision 5245

    Path3: Stopped Path3 looping when MskPath3 is enabled, reduces the amount the
    recompiler has to exit, yeilding a small speed boost (but it is really small!)

    danialho...
    it needs more desu

    avihal
    Hmm.. this revision breaks SSX3 (gets stuck before the first loading screen). It works on r5239, broken here and also broken on r5245, r5246, r5247, r5248 and r5260.

    hilldo...
    This revision breaks some other games such as AllStarProWrestling3. Maybe it should be included as an optional hack.

Revision 5265

    Path3 Regression Fix: Turns out part of the optimization in r5245 didn't work so
    well with SSX3, plus it didn't create much benefit.

    avihal
    That was quick! :)

    refraction
    No messin me ;p

[turtleli]

(turtleli - the new blockdump code didn't work in this scenario, the resulting file was - 2MB, the archive was invalid when I tried to extract it as a test. Using an older exe to build it, that file was 10MB and could be extracted by .7z without problems)

Why are you trying to extract it? v1 blockdump = ISO with missing data, v2 blockdump = tagged sectors.

[MrCK1]

Ah ok. Thanks for explaining the differences. I'm actually not sure if the blockdump I uploaded will work. I might have to dump one in 0.9.8, once I figure that out.

Edit: I did some minor code replacements last night but it didn't work. I think some of the changes between r5245-r5265 may have made the issue worse.

[refractionpcsx2]

I think I've fixed it, will upload shortly

Edit: Ok uploaded, try the latest build, if it doesn't fix it we can reopen. I wonder what other ones that never got fixed now work? :P

[MrCK1]

I'll try it out.

Edit: Looks good :)

[refractionpcsx2]

Cool :) I couldn't tell if the game gets much further as the dump runs out pretty quick lol

[MrCK1]

I'm testing out the rest of my games just to be sure, but I doubt there will be any regressions. Hopefully nobody else comes back in 5 years ;)

[refractionpcsx2]

Let's hope not :P

[refractionpcsx2]

Well it wasn't 5 years.. lol