Skip to content

Commit

Permalink
Gif: Don't set state on NOP packet. Fixes #2277
Browse files Browse the repository at this point in the history
  • Loading branch information
@refractionpcsx2
refractionpcsx2 committed Jan 26, 2018
1 parent 24b83fd commit f7c0a91
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pcsx2/Gif_Unit.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,10 @@ struct Gif_Path {
}

gifTag.setTag(&buffer[curOffset], 1);
state = (GIF_PATH_STATE)(gifTag.tag.FLG + 1);

//Don't set state to PACKED if it is a NOP packet
if(gifTag.tag.NLOOP > 0)
state = (GIF_PATH_STATE)(gifTag.tag.FLG + 1);

// We don't have enough data for a complete GS packet
if(!gifTag.hasAD && curOffset + 16 + gifTag.len > curSize) {
Expand Down

2 comments on commit f7c0a91

@FlatOutPS2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks Reservoir Dogs; https://forums.pcsx2.net/Thread-Reservoir-Dogs-bug

@refractionpcsx2
Copy link
Member Author

@refractionpcsx2 refractionpcsx2 commented on f7c0a91 Mar 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curses. Maybe I should be forcing the state to Idle.

Edit: Ok fixed in 6d7e2c5

Please sign in to comment.